Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 09:27, Christian Borntraeger wrote: > hmm, not quite. > This patch on top of > commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6 MAINTAINERS: Remove obsolete > stable branches > still triggers > > qemu-system-s390x: hw/s390x/virtio-ccw.c:1076: virtio_ccw_remove_irqfd: > Assertio

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-15 Thread Christian Borntraeger
On 11/10/2016 03:48 PM, Christian Borntraeger wrote: > On 11/10/2016 03:38 PM, Paolo Bonzini wrote: >> >> >> On 10/11/2016 15:35, Christian Borntraeger wrote: >>> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: From: Paolo Bonzini Now that there is not anymore a switch from the ge

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Christian Borntraeger
On 11/10/2016 03:38 PM, Paolo Bonzini wrote: > > > On 10/11/2016 15:35, Christian Borntraeger wrote: >> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >>> From: Paolo Bonzini >>> >>> Now that there is not anymore a switch from the generic ioeventfd handler >>> to the dataplane handler, virtio

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 15:35, Christian Borntraeger wrote: > On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >> From: Paolo Bonzini >> >> Now that there is not anymore a switch from the generic ioeventfd handler >> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is >> always called

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Christian Borntraeger
On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: > From: Paolo Bonzini > > Now that there is not anymore a switch from the generic ioeventfd handler > to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is > always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeven

[Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-10-30 Thread Michael S. Tsirkin
From: Paolo Bonzini Now that there is not anymore a switch from the generic ioeventfd handler to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd does nothing in this case. Move the invocation to vhost