Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 10:55, Peter Maydell wrote: > Yes, that would make sense. But why do we need to do more > full invalidates now? Because the board doesn't call memory_region_set_log. > > You can just add a memory_region_set_log call for the integratorcp and > > versatilepb RAM regions. > > It see

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 07:48, Paolo Bonzini wrote: > > > On 13/07/2015 00:02, Peter Maydell wrote: >> (I'm wondering if we somehow manage to spend all our time >> trying to service the GUI and no time making forward >> progress in the guest, though I don't have a clear idea >> in mind of why this woul

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Paolo Bonzini
On 13/07/2015 00:02, Peter Maydell wrote: > (I'm wondering if we somehow manage to spend all our time > trying to service the GUI and no time making forward > progress in the guest, though I don't have a clear idea > in mind of why this would be so Perhaps because Xlib calls (and hence GTK+ call

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Peter Maydell
On 12 July 2015 at 15:09, Paolo Bonzini wrote: > > > On 10/07/2015 17:44, Peter Maydell wrote: >> I've just noticed that one of my vexpress-a9 test images has >> regressed, and git bisect suggests this commit (d55d42078bfb50) >> is at fault. >> >> Test image (512MB) >> http://people.linaro.org/~pe

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-12 Thread Paolo Bonzini
On 10/07/2015 17:44, Peter Maydell wrote: > I've just noticed that one of my vexpress-a9 test images has > regressed, and git bisect suggests this commit (d55d42078bfb50) > is at fault. > > Test image (512MB) > http://people.linaro.org/~peter.maydell/vexpress-3.8.tgz > Untar anywhere, and run wi

Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-07-10 Thread Peter Maydell
On 5 June 2015 at 16:15, Paolo Bonzini wrote: > framebuffer.c expects DIRTY_MEMORY_VGA logging to be always on, but that > will not be the case soon. Because framebuffer.c computes the memory > region on the fly for every update (with memory_region_find), it cannot > enable/disable logging by its

[Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging

2015-06-05 Thread Paolo Bonzini
framebuffer.c expects DIRTY_MEMORY_VGA logging to be always on, but that will not be the case soon. Because framebuffer.c computes the memory region on the fly for every update (with memory_region_find), it cannot enable/disable logging by itself. Instead, always treat updates as invalidations if