Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-26 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini This patch postpones vapic_paddr initialization, which is performed during migration. When vapic_paddr is synchronized within the migration process, apic_common functions could operate with incorrect apic

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-26 Thread Paolo Bonzini
Il 26/09/2014 13:18, Pavel Dovgaluk ha scritto: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini This patch postpones vapic_paddr initialization, which is performed during migration. When vapic_paddr is synchronized within the migration process, apic_common

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-22 Thread Pavel Dovgaluk
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Friday, September 19, 2014 5:42 PM To: Pavel Dovgaluk; qemu-devel@nongnu.org Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix Il 19/09/2014 14:50, Pavel Dovgaluk ha scritto:

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 10:21, Pavel Dovgaluk ha scritto: -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Friday, September 19, 2014 5:42 PM To: Pavel Dovgaluk; qemu-devel@nongnu.org Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix Il

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Pavel Dovgaluk
Hi, Paolo! From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini From: Pavel Dovgalyuk pavel.dovga...@ispras.ru This patch postpones vapic_paddr initialization, which is performed during migration. When vapic_paddr is synchronized within the migration process,

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Paolo Bonzini
Il 19/09/2014 12:43, Pavel Dovgaluk ha scritto: I've tested this patch with replay. I enabled VM reset (which was previously disabled for replay) while loading the VM state and discovered the following problem. vapic_enable function in kvmapic.c retrieves cpu number with the

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 19/09/2014 12:43, Pavel Dovgaluk ha scritto: I've tested this patch with replay. I enabled VM reset (which was previously disabled for replay) while loading the VM state and discovered the following

Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-19 Thread Paolo Bonzini
Il 19/09/2014 14:50, Pavel Dovgaluk ha scritto: vapic_paddr depends on cpu_number. cpu_number cannot be retrieved when do_vapic_enable executes. Thus we cannot reconstruct vapic_paddr in that function. cpu_number will always be zero, because do_vapic_enable is only executed for smp_cpus == 1.

[Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix

2014-09-12 Thread Paolo Bonzini
From: Pavel Dovgalyuk pavel.dovga...@ispras.ru This patch postpones vapic_paddr initialization, which is performed during migration. When vapic_paddr is synchronized within the migration process, apic_common functions could operate with incorrect apic state, if it hadn't loaded yet. This patch