Re: [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

2014-10-17 Thread Peter Maydell
On 17 October 2014 19:02, Peter Maydell wrote: > On 17 October 2014 18:57, Michael Tokarev wrote: >> On 10/17/2014 08:53 PM, Peter Maydell wrote: >>> g_assert_cmpint() was only added in glib 2.16, so this won't >>> build on glib 2.12. A compat fudge in glib-compat.h should >>> be easy, though. >>

Re: [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

2014-10-17 Thread Peter Maydell
On 17 October 2014 18:57, Michael Tokarev wrote: > On 10/17/2014 08:53 PM, Peter Maydell wrote: >> g_assert_cmpint() was only added in glib 2.16, so this won't >> build on glib 2.12. A compat fudge in glib-compat.h should >> be easy, though. > > Or just change this to regular in-line comparison an

Re: [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

2014-10-17 Thread Michael Tokarev
On 10/17/2014 08:53 PM, Peter Maydell wrote: > On 4 October 2014 22:24, Stefan Hajnoczi wrote: >> From: John Snow >> >> This patch implements the backend for the Q35 board >> for us to be able to pick up and use drives defined >> by the -cdrom, -hda, or -drive if=ide shorthand options. >> >> Sign

Re: [Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

2014-10-17 Thread Peter Maydell
On 4 October 2014 22:24, Stefan Hajnoczi wrote: > From: John Snow > > This patch implements the backend for the Q35 board > for us to be able to pick up and use drives defined > by the -cdrom, -hda, or -drive if=ide shorthand options. > > Signed-off-by: John Snow > Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL 13/23] q35/ahci: Pick up -cdrom and -hda options

2014-10-04 Thread Stefan Hajnoczi
From: John Snow This patch implements the backend for the Q35 board for us to be able to pick up and use drives defined by the -cdrom, -hda, or -drive if=ide shorthand options. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Message-id: 1412187569-23452