On Fri, Jan 08, 2016 at 10:05:44AM +0100, Paolo Bonzini wrote:
>
>
> On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> > +{
> > +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
>
> Off by one. The check should be >=, not >.
>
> Paolo
Corey, can you look into this
On 12/01/2016 12:06, Michael S. Tsirkin wrote:
>>> > > +{
>>> > > +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2]))
>>> > > {
>> >
>> > Off by one. The check should be >=, not >.
>> >
>> > Paolo
> Corey, can you look into this please?
>
He already posted some fixes
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +{
> +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
Off by one. The check should be >=, not >.
Paolo
> +return -1;
> +}
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +case IPMI_BMC_WATCHDOG_PRE_NMI:
> +if (!k->do_hw_op(s, IPMI_SEND_NMI, 1)) {
> +/* NMI not supported. */
> +rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> +goto out;
> +}
> +default:
> +
From: Corey Minyard
This provides a minimal local BMC, basically enough to comply with the
spec and provide a complete watchdog timer (including a sensor, SDR,
and event).
Signed-off-by: Corey Minyard
Reviewed-by: Michael S. Tsirkin