On Mon, Feb 04, 2019 at 08:48:14PM -0500, Michael S. Tsirkin wrote:
> On Mon, Feb 04, 2019 at 03:29:21PM +, Daniel P. Berrangé wrote:
> > On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote:
> > > Hmm I do think we want to build the contrib tools,
> > > otherwise they bitrot too
On Mon, Feb 04, 2019 at 03:29:21PM +, Daniel P. Berrangé wrote:
> On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote:
> > Hmm I do think we want to build the contrib tools,
> > otherwise they bitrot too quickly, witness follow-up
> > patches that fix the compilation.
> >
> > An
On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote:
> Hmm I do think we want to build the contrib tools,
> otherwise they bitrot too quickly, witness follow-up
> patches that fix the compilation.
>
> And I think we need tests that actually use them.
>
> However I agree adding them
No explanation of /why/ we want to build this by default ?
The source header calls it a demo application and it has no man
page.
Given this IMHO we should *not* be building & installing it by
default, as doing so defacto turns it into a user tool we have
to support.
On Mon, Feb 04, 2019 at 09
Hmm I do think we want to build the contrib tools,
otherwise they bitrot too quickly, witness follow-up
patches that fix the compilation.
And I think we need tests that actually use them.
However I agree adding them to tools and installing
is probably rushing things, e.g. there's no
manpage even.
From: Changpeng Liu
Signed-off-by: Changpeng Liu
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index 31cf6f584d..5c619d
