Re: [Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-06-05 Thread Peter Xu
On Tue, Jun 05, 2018 at 03:48:09PM +0800, Peter Xu wrote: [...] > > There are also a couple of other things Coverity thinks might > > be data race conditions (CID 1391295 and CID 1391288) that you > > might want to look at, though I suspect they are false-positives > > (access occurs before threa

Re: [Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-06-05 Thread Peter Xu
On Mon, Jun 04, 2018 at 02:49:58PM +0100, Peter Maydell wrote: > On 16 May 2018 at 00:39, Juan Quintela wrote: > > From: Peter Xu > > > > When there is IO error on the incoming channel (e.g., network down), > > instead of bailing out immediately, we allow the dst vm to switch to the > > new POSTC

Re: [Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-06-04 Thread Peter Maydell
On 16 May 2018 at 00:39, Juan Quintela wrote: > From: Peter Xu > > When there is IO error on the incoming channel (e.g., network down), > instead of bailing out immediately, we allow the dst vm to switch to the > new POSTCOPY_PAUSE state. Currently it is still simple - it waits the > new semaphor

[Qemu-devel] [PULL 16/40] migration: allow dst vm pause on postcopy

2018-05-15 Thread Juan Quintela
From: Peter Xu When there is IO error on the incoming channel (e.g., network down), instead of bailing out immediately, we allow the dst vm to switch to the new POSTCOPY_PAUSE state. Currently it is still simple - it waits the new semaphore, until someone poke it for another attempt. One note is