Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-15 Thread Eric Auger
Hi Peter, On 06/12/2015 08:04 PM, Peter Crosthwaite wrote: > On Fri, Jun 12, 2015 at 3:04 AM, Peter Maydell > wrote: >> On 12 June 2015 at 09:53, Eric Auger wrote: >>> On 06/12/2015 10:25 AM, Eric Auger wrote: > I think it is because this is now delaying > arm_load_kernel_notify call un

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-12 Thread Peter Maydell
On 12 June 2015 at 19:04, Peter Crosthwaite wrote: > So Eric's cpu reset re-ordering patch does fix it. But I thought we > were trying to make reset ordering independent? I think it would be more accurate to say that we hope reset ordering is independent because we have no good way of describing

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-12 Thread Peter Crosthwaite
On Fri, Jun 12, 2015 at 3:04 AM, Peter Maydell wrote: > On 12 June 2015 at 09:53, Eric Auger wrote: >> On 06/12/2015 10:25 AM, Eric Auger wrote: I think it is because this is now delaying arm_load_kernel_notify call until after rom_load_all. From vl.c: if (rom_load_all()

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-12 Thread Peter Maydell
On 12 June 2015 at 09:53, Eric Auger wrote: > On 06/12/2015 10:25 AM, Eric Auger wrote: >>> I think it is because this is now delaying >>> arm_load_kernel_notify call until after rom_load_all. From vl.c: >>> >>> if (rom_load_all() != 0) { >>> fprintf(stderr, "rom loading failed\n"); >

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-12 Thread Eric Auger
On 06/12/2015 10:25 AM, Eric Auger wrote: > Hi Peter, > On 06/12/2015 04:54 AM, Peter Crosthwaite wrote: >> On Tue, Jun 2, 2015 at 9:33 AM, Peter Maydell >> wrote: >>> From: Eric Auger >>> >>> Device tree nodes for the platform bus and its children dynamic sysbus >>> devices are added in a machi

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-12 Thread Eric Auger
Hi Peter, On 06/12/2015 04:54 AM, Peter Crosthwaite wrote: > On Tue, Jun 2, 2015 at 9:33 AM, Peter Maydell > wrote: >> From: Eric Auger >> >> Device tree nodes for the platform bus and its children dynamic sysbus >> devices are added in a machine init done notifier. To load the dtb once, >> afte

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-11 Thread Peter Crosthwaite
On Tue, Jun 2, 2015 at 9:33 AM, Peter Maydell wrote: > From: Eric Auger > > Device tree nodes for the platform bus and its children dynamic sysbus > devices are added in a machine init done notifier. To load the dtb once, > after those latter nodes are built and before ROM freeze, the actual > ar

[Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-02 Thread Peter Maydell
From: Eric Auger Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify funct