Re: [Qemu-devel] [PULL 21/26] target-hppa: Implement branches

2017-01-26 Thread Richard Henderson
On 01/26/2017 04:14 AM, Paolo Bonzini wrote: I haven't studied the code much, so I'm just reporting what Coverity says. Not sure if the code has a bug or can just be simplified. It looks like it can be simplified. I'm sure at one point in the development, "which" was not a constant like

Re: [Qemu-devel] [PULL 21/26] target-hppa: Implement branches

2017-01-26 Thread Paolo Bonzini
I haven't studied the code much, so I'm just reporting what Coverity says. Not sure if the code has a bug or can just be simplified. On 23/01/2017 03:17, Richard Henderson wrote: > +/* Emit a conditional branch to a direct target. If the branch itself > + is nullified, we should have already

[Qemu-devel] [PULL 21/26] target-hppa: Implement branches

2017-01-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 477 1 file changed, 477 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 2ad651c..1d0976f 100644 --- a/target/hppa/translate.c +++