Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Jan Kiszka
On 10.07.19 18:34, Paolo Bonzini wrote: > On 10/07/19 18:08, Jan Kiszka wrote: >> On 10.07.19 16:40, Paolo Bonzini wrote: >>> On 08/07/19 20:31, Jan Kiszka wrote: > -if (cpu_has_nested_virt(env) && !env->nested_state) { > +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state)

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Paolo Bonzini
On 10/07/19 18:08, Jan Kiszka wrote: > On 10.07.19 16:40, Paolo Bonzini wrote: >> On 08/07/19 20:31, Jan Kiszka wrote: -if (cpu_has_nested_virt(env) && !env->nested_state) { +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state) { error_report("Guest enabled n

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Jan Kiszka
On 10.07.19 16:40, Paolo Bonzini wrote: > On 08/07/19 20:31, Jan Kiszka wrote: >>> -if (cpu_has_nested_virt(env) && !env->nested_state) { >>> +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state) { >>> error_report("Guest enabled nested virtualization but kernel " >>>

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-10 Thread Paolo Bonzini
On 08/07/19 20:31, Jan Kiszka wrote: >> -if (cpu_has_nested_virt(env) && !env->nested_state) { >> +if (kvm_enabled() && cpu_has_vmx(env) && !env->nested_state) { >> error_report("Guest enabled nested virtualization but kernel " >> "does not support saving of nested

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-08 Thread Jan Kiszka
On 08.07.19 20:31, Jan Kiszka wrote: > > On 21.06.19 13:30, Paolo Bonzini wrote: >> From: Liran Alon >> >> Previous commits have added support for migration of nested virtualization >> workloads. This was done by utilising two new KVM capabilities: >> KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PA

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-07-08 Thread Jan Kiszka
On 21.06.19 13:30, Paolo Bonzini wrote: > From: Liran Alon > > Previous commits have added support for migration of nested virtualization > workloads. This was done by utilising two new KVM capabilities: > KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are > required in order to

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Liran Alon
> On 21 Jun 2019, at 20:27, Paolo Bonzini wrote: > > On 21/06/19 17:07, Liran Alon wrote: >>> So, overall I prefer not to block migration. >> I’m not sure I agree. >> It is quite likely that vCPU is currently in guest-mode while you are >> migrating… >> A good hypervisor tries to maximise CPU

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Paolo Bonzini
On 21/06/19 17:07, Liran Alon wrote: >> So, overall I prefer not to block migration. > I’m not sure I agree. > It is quite likely that vCPU is currently in guest-mode while you are > migrating… > A good hypervisor tries to maximise CPU time to be in guest-mode rather than > host-mode. :) True, b

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Liran Alon
> On 21 Jun 2019, at 18:02, Paolo Bonzini wrote: > > On 21/06/19 14:39, Liran Alon wrote: >>> On 21 Jun 2019, at 14:30, Paolo Bonzini wrote: >>> >>> From: Liran Alon >>> >>> Previous commits have added support for migration of nested virtualization >>> workloads. This was done by utilising

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Paolo Bonzini
On 21/06/19 14:39, Liran Alon wrote: >> On 21 Jun 2019, at 14:30, Paolo Bonzini wrote: >> >> From: Liran Alon >> >> Previous commits have added support for migration of nested virtualization >> workloads. This was done by utilising two new KVM capabilities: >> KVM_CAP_NESTED_STATE and KVM_CAP_EXC

Re: [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Liran Alon
> On 21 Jun 2019, at 14:30, Paolo Bonzini wrote: > > From: Liran Alon > > Previous commits have added support for migration of nested virtualization > workloads. This was done by utilising two new KVM capabilities: > KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are > requir

[Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-21 Thread Paolo Bonzini
From: Liran Alon Previous commits have added support for migration of nested virtualization workloads. This was done by utilising two new KVM capabilities: KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are required in order to correctly migrate such workloads. Therefore, change

[Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

2019-06-20 Thread Paolo Bonzini
From: Liran Alon Previous commits have added support for migration of nested virtualization workloads. This was done by utilising two new KVM capabilities: KVM_CAP_NESTED_STATE and KVM_CAP_EXCEPTION_PAYLOAD. Both which are required in order to correctly migrate such workloads. Therefore, change