Re: [Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-24 Thread Cédric Le Goater
On 08/24/2018 05:38 PM, Greg Kurz wrote: > On Fri, 24 Aug 2018 17:30:12 +0200 > Cédric Le Goater wrote: > >> On 08/24/2018 05:09 PM, Peter Maydell wrote: >>> On 21 August 2018 at 05:33, David Gibson >>> wrote: From: Cédric Le Goater It should save us some CPU cycles as these r

Re: [Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-24 Thread Greg Kurz
On Fri, 24 Aug 2018 17:30:12 +0200 Cédric Le Goater wrote: > On 08/24/2018 05:09 PM, Peter Maydell wrote: > > On 21 August 2018 at 05:33, David Gibson > > wrote: > >> From: Cédric Le Goater > >> > >> It should save us some CPU cycles as these routines perform a lot of > >> checks. > >> > >>

Re: [Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-24 Thread Cédric Le Goater
On 08/24/2018 05:09 PM, Peter Maydell wrote: > On 21 August 2018 at 05:33, David Gibson wrote: >> From: Cédric Le Goater >> >> It should save us some CPU cycles as these routines perform a lot of >> checks. >> >> Signed-off-by: Cédric Le Goater >> Signed-off-by: David Gibson >> --- >> hw/ppc/s

Re: [Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-24 Thread Peter Maydell
On 21 August 2018 at 05:33, David Gibson wrote: > From: Cédric Le Goater > > It should save us some CPU cycles as these routines perform a lot of > checks. > > Signed-off-by: Cédric Le Goater > Signed-off-by: David Gibson > --- > hw/ppc/spapr_pci.c | 11 ++- > 1 file changed, 6 inserti

[Qemu-devel] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-20 Thread David Gibson
From: Cédric Le Goater It should save us some CPU cycles as these routines perform a lot of checks. Signed-off-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/sp