Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-09 Thread Wen Congyang
At 2015/7/9 20:51, Paolo Bonzini Wrote: On 09/07/2015 10:14, Wen Congyang wrote: flush_compressed_data(f); ram_control_after_iterate(f, RAM_CONTROL_FINISH); -migration_end(); - rcu_read_unlock(); + +migration_end(); qemu_put_be64(f, RAM_SAVE_FLAG_EOS); Yes, th

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 10:14, Wen Congyang wrote: > > flush_compressed_data(f); > > ram_control_after_iterate(f, RAM_CONTROL_FINISH); > > -migration_end(); > > - > > rcu_read_unlock(); > > + > > +migration_end(); > > qemu_put_be64(f, RAM_SAVE_FLAG_EOS); > > Yes, this patch can

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-09 Thread Wen Congyang
On 07/09/2015 03:59 PM, Paolo Bonzini wrote: > > > On 09/07/2015 03:19, Wen Congyang wrote: >> Yes, why migration doesn't trigger this problem? We will fix it soon. > > This should be the fix if someone wants to test it and/or post it: > > diff --git a/migration/ram.c b/migration/ram.c > index

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 03:19, Wen Congyang wrote: > Yes, why migration doesn't trigger this problem? We will fix it soon. This should be the fix if someone wants to test it and/or post it: diff --git a/migration/ram.c b/migration/ram.c index 57368e1..8d5a73a 100644 --- a/migration/ram.c +++ b/migration/

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-08 Thread Wen Congyang
On 07/09/2015 04:35 AM, Paolo Bonzini wrote: > > > On 08/07/2015 21:13, Kevin Wolf wrote: >> Am 07.07.2015 um 15:09 hat Juan Quintela geschrieben: >>> From: Li Zhijian >>> >>> Signed-off-by: Li Zhijian >>> Signed-off-by: Wen Congyang >>> Signed-off-by: Juan Quintela >>> --- >>> migration/ram

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 21:13, Kevin Wolf wrote: > Am 07.07.2015 um 15:09 hat Juan Quintela geschrieben: >> From: Li Zhijian >> >> Signed-off-by: Li Zhijian >> Signed-off-by: Wen Congyang >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 23 +-- >> 1 file changed, 17 inse

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-08 Thread Kevin Wolf
Am 07.07.2015 um 15:09 hat Juan Quintela geschrieben: > From: Li Zhijian > > Signed-off-by: Li Zhijian > Signed-off-by: Wen Congyang > Signed-off-by: Juan Quintela > --- > migration/ram.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletions(-) In current master, HMP

[Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

2015-07-07 Thread Juan Quintela
From: Li Zhijian Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Signed-off-by: Juan Quintela --- migration/ram.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 644f52a..9c0bcfe 100644 --- a/migration/