Re: [Qemu-devel] [PULL 27/32] qapi: add #if conditions to generated code members

2018-12-13 Thread Markus Armbruster
Eric Blake writes: > On 12/13/18 12:43 PM, Markus Armbruster wrote: >> From: Marc-André Lureau >> >> Wrap generated enum and struct members and their supporting code with >> > > Git ate the line because it started with #. Not sure if you can sneak > in a v2 pull request that puts something

Re: [Qemu-devel] [PULL 27/32] qapi: add #if conditions to generated code members

2018-12-13 Thread Eric Blake
On 12/13/18 12:43 PM, Markus Armbruster wrote: From: Marc-André Lureau Wrap generated enum and struct members and their supporting code with Git ate the line because it started with #. Not sure if you can sneak in a v2 pull request that puts something sane here... We do enum and struct

[Qemu-devel] [PULL 27/32] qapi: add #if conditions to generated code members

2018-12-13 Thread Markus Armbruster
From: Marc-André Lureau Wrap generated enum and struct members and their supporting code with We do enum and struct in a single patch because union tag enum and the associated variants tie them together, and dealing with that to split the patch doesn't seem worthwhile. Signed-off-by: