Re: [Qemu-devel] [PULL 32/46] scsi: provide general-purpose functions to manage sense data

2017-12-22 Thread Roman Kagan
On Wed, Dec 20, 2017 at 06:14:44PM +0100, Paolo Bonzini wrote: > @@ -274,52 +319,21 @@ const struct SCSISense sense_code_SPACE_ALLOC_FAILED = { > int scsi_convert_sense(uint8_t *in_buf, int in_len, > uint8_t *buf, int len, bool fixed) > { > -bool fixed_in; > SCSIS

[Qemu-devel] [PULL 32/46] scsi: provide general-purpose functions to manage sense data

2017-12-20 Thread Paolo Bonzini
Extract the common parts of scsi_sense_buf_to_errno, scsi_convert_sense and scsi_target_send_command's REQUEST SENSE handling into two new functions scsi_parse_sense_buf and scsi_build_sense_buf. Fix a bug in scsi_target_send_command along the way; the length was written in buf[10] rather than buf