Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support

2013-12-09 Thread Paolo Bonzini
Il 06/12/2013 23:36, Alex Williamson ha scritto: >>> > > #define VFIO_ALLOW_MMAP 1 >>> > > #define VFIO_ALLOW_KVM_INTX 1 >>> > > +#define VFIO_ALLOW_KVM_MSI 1 >>> > > +#define VFIO_ALLOW_KVM_MSIX 1 >> > >> > Why not make these device properties instead? > Honestly, I don't think they're that use

Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support

2013-12-06 Thread Alex Williamson
On Fri, 2013-12-06 at 23:06 +0100, Paolo Bonzini wrote: > Il 06/12/2013 21:48, Alex Williamson ha scritto: > > /* Extra debugging, trap acceleration paths for more logging */ > > #define VFIO_ALLOW_MMAP 1 > > #define VFIO_ALLOW_KVM_INTX 1 > > +#define VFIO_ALLOW_KVM_MSI 1 > > +#define VFIO_ALLOW

Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support

2013-12-06 Thread Paolo Bonzini
Il 06/12/2013 21:48, Alex Williamson ha scritto: > /* Extra debugging, trap acceleration paths for more logging */ > #define VFIO_ALLOW_MMAP 1 > #define VFIO_ALLOW_KVM_INTX 1 > +#define VFIO_ALLOW_KVM_MSI 1 > +#define VFIO_ALLOW_KVM_MSIX 1 Why not make these device properties instead? Paolo

[Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support

2013-12-06 Thread Alex Williamson
It's sometimes useful to be able to verify interrupts are passing through correctly. Signed-off-by: Alex Williamson --- hw/misc/vfio.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 09bdddf..f367537 100644 ---