Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-07 Thread Kevin Wolf
Am 06.04.2017 um 23:29 hat Richard W.M. Jones geschrieben: > On Thu, Apr 06, 2017 at 04:23:19PM -0500, Eric Blake wrote: > > On 04/06/2017 04:15 PM, Richard W.M. Jones wrote: > > > > +++ b/block/io.c > > @@ -945,6 +945,8 @@ static int coroutine_fn > >

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-06 Thread Richard W.M. Jones
On Thu, Apr 06, 2017 at 04:23:19PM -0500, Eric Blake wrote: > On 04/06/2017 04:15 PM, Richard W.M. Jones wrote: > > +++ b/block/io.c > @@ -945,6 +945,8 @@ static int coroutine_fn > bdrv_co_do_copy_on_readv(BdrvChild *child, > size_t skip_bytes; > int ret; >

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-06 Thread Eric Blake
On 04/06/2017 04:15 PM, Richard W.M. Jones wrote: +++ b/block/io.c @@ -945,6 +945,8 @@ static int coroutine_fn bdrv_co_do_copy_on_readv(BdrvChild *child, size_t skip_bytes; int ret; +assert(child->perm & (BLK_PERM_WRITE_UNCHANGED |

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-06 Thread Richard W.M. Jones
On Thu, Apr 06, 2017 at 04:03:28PM -0500, Eric Blake wrote: > On 04/06/2017 03:59 PM, Richard W.M. Jones wrote: > > On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote: > >> This adds assertions that ensure that the necessary write permissions > >> have been granted before someone attempts

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-06 Thread Eric Blake
On 04/06/2017 03:59 PM, Richard W.M. Jones wrote: > On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote: >> This adds assertions that ensure that the necessary write permissions >> have been granted before someone attempts to write to a node. >> >> Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-04-06 Thread Richard W.M. Jones
On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote: > This adds assertions that ensure that the necessary write permissions > have been granted before someone attempts to write to a node. > > Signed-off-by: Kevin Wolf > Acked-by: Fam Zheng >

[Qemu-devel] [PULL 43/46] block: Assertions for write permissions

2017-02-28 Thread Kevin Wolf
This adds assertions that ensure that the necessary write permissions have been granted before someone attempts to write to a node. Signed-off-by: Kevin Wolf Acked-by: Fam Zheng Reviewed-by: Max Reitz --- block/io.c | 3 +++ 1 file