[Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-22 Thread arei.gonglei
From: Gonglei It will be useful for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &local_err to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc:

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Gonglei
On 2014/12/16 21:23, Peter Maydell wrote: > On 16 December 2014 at 13:04, Gonglei wrote: >> On 2014/12/16 20:42, Peter Maydell wrote: >> >>> On 16 December 2014 at 09:22, wrote: @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size, object_

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 13:04, Gonglei wrote: > On 2014/12/16 20:42, Peter Maydell wrote: > >> On 16 December 2014 at 09:22, wrote: >>> @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t >>> above_4g_mem_size, >>> object_property_set_link(OBJECT(machine), OBJECT(s), >>>

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Gonglei
On 2014/12/16 20:42, Peter Maydell wrote: > On 16 December 2014 at 09:22, wrote: >> @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t >> above_4g_mem_size, >> object_property_set_link(OBJECT(machine), OBJECT(s), >> "rtc_state", &error_abort

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 09:22, wrote: > @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t > above_4g_mem_size, > object_property_set_link(OBJECT(machine), OBJECT(s), > "rtc_state", &error_abort); > > -if (set_boot_dev(s, boot_device)) { >

[Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread arei.gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &error_abort to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc: q

[Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread arei . gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &error_abort to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc: q