Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread Gerd Hoffmann
Hi, > > +DEFINE_PROP_BOOL("blitter", struct PCICirrusVGAState, > > > + cirrus_vga.enable_blitter, true), > > > The default is 'ENABLE'? Yes. > I think there should be 'false'. Just flipping it to false isn't an option. At minimum we would have to keep it enabled b

Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread Thomas Huth
org >> Cc: Gerd Hoffmann >> Subject: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable >> blitter >> >> Ok, we have this beast in the cirrus code which is not used at all by modern >> guests, except when you try to find security holes in qemu. So, a

Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread 李强
Hello Gerd, > -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+liqiang6-s=360...@nongnu.org] On Behalf Of > Gerd Hoffmann > Sent: Thursday, March 16, 2017 5:31 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [PULL

[Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread Gerd Hoffmann
Ok, we have this beast in the cirrus code which is not used at all by modern guests, except when you try to find security holes in qemu. So, add an option to disable blitter altogether. Guests released within the last ten years should not show any rendering issues if you turn off blitter support.