Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
Hi, > If you need to fix up somebody else's patch because they've > dumped it on the list and run away without fixing review > issues, the right way to do this is: > * retain their email as the author > * retain their Signed-off-by line > * after that, include a brief summary in square bracke

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
On Do, 2014-02-27 at 06:55 -0700, Eric Blake wrote: > git config diff.renames true Thanks. Gerd signature.asc Description: This is a digitally signed message part

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Eric Blake
On 02/27/2014 06:19 AM, Gerd Hoffmann wrote: >> I hate bouncing this pull request for a second time, but >> this still contains stuff that's obviously not ready: >> * patch which adds a 1000 line new file, then another >>patch 2 commits later deletes 100 of those lines > > That is just a case

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Peter Maydell
On 27 February 2014 13:19, Gerd Hoffmann wrote: >> I hate bouncing this pull request for a second time, but >> this still contains stuff that's obviously not ready: >> * patch which adds a 1000 line new file, then another >>patch 2 commits later deletes 100 of those lines > > That is just a c

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
> I hate bouncing this pull request for a second time, but > this still contains stuff that's obviously not ready: > * patch which adds a 1000 line new file, then another >patch 2 commits later deletes 100 of those lines That is just a case of having forgotten to specify '-M' switch for git-f

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-26 Thread Peter Maydell
On 24 February 2014 11:52, Gerd Hoffmann wrote: > Hi, > > The input layer moves to a model modeled roughly after the linux > event layer. It also uses qapi to create all the data types needed. > First, because it is convinient to have all the support code generated, > and also to make it easier

[Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-24 Thread Gerd Hoffmann
Hi, The input layer moves to a model modeled roughly after the linux event layer. It also uses qapi to create all the data types needed. First, because it is convinient to have all the support code generated, and also to make it easier to integrate with qmp some day. Porting work has only be d