Philippe Mathieu-Daudé writes:
> On 5/14/19 5:48 PM, Alex Bennée wrote:
>>
>> Aleksandar Markovic writes:
>>
>>> On May 10, 2019 8:57 PM, "Richard Henderson"
>>> wrote:
>>>
>>> Please change the title to 'target/mips: Switch to using
>>> mips_cpu_tlb_fill()', or something along that
On Tue, 14 May 2019 at 17:05, Aleksandar Markovic
wrote:
> I am not complaining about myself looking at another commit message, but have
> future maintainers and future developers in mind. Their effort needed for
> deciphering commit messages like this one is multiple times larger than
>
On 5/14/19 5:48 PM, Alex Bennée wrote:
>
> Aleksandar Markovic writes:
>
>> On May 10, 2019 8:57 PM, "Richard Henderson"
>> wrote:
>>>
>>
>> Please change the title to 'target/mips: Switch to using
>> mips_cpu_tlb_fill()', or something along that line.
>
> It does seem a little redundant as
On May 14, 2019 5:26 PM, "Peter Maydell" wrote:
>
> On Sat, 11 May 2019 at 14:43, Aleksandar Markovic
> wrote:
> > This commit message is generally poor, as it explains relatively
unimportant logging issue, while not explaining the core of the change.
>
> I think the assumption with this sort of
Aleksandar Markovic writes:
> On May 10, 2019 8:57 PM, "Richard Henderson"
> wrote:
>>
>
> Please change the title to 'target/mips: Switch to using
> mips_cpu_tlb_fill()', or something along that line.
It does seem a little redundant as "target/mips:" already marks it as a
mips specific
On Sat, 11 May 2019 at 14:43, Aleksandar Markovic
wrote:
> This commit message is generally poor, as it explains relatively unimportant
> logging issue, while not explaining the core of the change.
I think the assumption with this sort of "refactor to change
all instances of an API" change is
On May 10, 2019 8:57 PM, "Richard Henderson"
wrote:
>
Please change the title to 'target/mips: Switch to using
mips_cpu_tlb_fill()', or something along that line.
Also, the reason for changing the field access_type to mips_access type
should be explained in the commit message.
This commit
Note that env->active_tc.PC is removed from the qemu_log as that value
is garbage. The PC isn't recovered until cpu_restore_state, called from
cpu_loop_exit_restore, called from do_raise_exception_err.
Cc: Aleksandar Markovic
Cc: Aleksandar Rikalo
Reviewed-by: Philippe Mathieu-Daudé
