Re: [Qemu-devel] [PULL v2 13/32] qmp: Revert change to handle_qmp_command tracepoint

2018-07-19 Thread Peter Maydell
On 19 July 2018 at 13:22, Markus Armbruster wrote: > Peter Maydell writes: >> Coverity CID 1394216 points out that in this function a >> little earlier we did a check on "if (!req && !err)", which >> implies that we can get here with a NULL req pointer, >> which will crash in qobject_to_json(). >

Re: [Qemu-devel] [PULL v2 13/32] qmp: Revert change to handle_qmp_command tracepoint

2018-07-19 Thread Markus Armbruster
Peter Maydell writes: > On 3 July 2018 at 22:35, Markus Armbruster wrote: >> Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved >> the handle_qmp_command tracepoint from handle_qmp_command() to >> monitor_qmp_dispatch_one(). This delays tracing from enqueue time to >> dequeu

Re: [Qemu-devel] [PULL v2 13/32] qmp: Revert change to handle_qmp_command tracepoint

2018-07-19 Thread Peter Maydell
On 3 July 2018 at 22:35, Markus Armbruster wrote: > Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved > the handle_qmp_command tracepoint from handle_qmp_command() to > monitor_qmp_dispatch_one(). This delays tracing from enqueue time to > dequeue time. Revert that. Dequeue

[Qemu-devel] [PULL v2 13/32] qmp: Revert change to handle_qmp_command tracepoint

2018-07-03 Thread Markus Armbruster
Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved the handle_qmp_command tracepoint from handle_qmp_command() to monitor_qmp_dispatch_one(). This delays tracing from enqueue time to dequeue time. Revert that. Dequeue remains adequately visible via tracepoint monitor_qmp_cmd_