Hi,
+trace_usb_mtp_op_get_device_info(s-dev.addr);
+
+usb_mtp_add_u16(d, 0x0100);
Sect. 5.1.1.1 says:
This identifies the PTP version this device can support in
hundredths. For MTP devices implemented under this specification,
this shall contain the value 100
On Thursday 24 April 2014 17:01:47 Gerd Hoffmann wrote:
PS: Funny thing that the reviews start coming in when I send pull
requests. The patches have been on the list a few weeks back
already (during 2.0 freeze, thats why the long delay between
[patch] and [pull]). No comments.
Hi,
For this review, I grabbed the MTP 1.1 spec from USB.org. There are some
issues which are noted below.
On Wednesday 23 April 2014 10:31:01 Gerd Hoffmann wrote:
Implementation of a USB Media Transfer Device device for easy
filesharing. Read-only. No access control inside qemu, it will
Hi,
Just a quick review. If I understand correctly, the guest never sends
filenames to the guest. Instead filenames are discovered using readdir
inside QEMU and the guest accesses objects by handle.
Correct.
This seems like a
good property for security since it eliminates '..' escaping
On Wed, Apr 23, 2014 at 10:31:01AM +0200, Gerd Hoffmann wrote:
Just a quick review. If I understand correctly, the guest never sends
filenames to the guest. Instead filenames are discovered using readdir
inside QEMU and the guest accesses objects by handle. This seems like a
good property for
On 04/24/2014 07:21 AM, Stefan Hajnoczi wrote:
+static void usb_mtp_object_readdir(MTPState *s, MTPObject *o)
+{
+struct dirent *entry;
+DIR *dir;
+
+o-nchildren = 0;
+dir = opendir(o-path);
+if (!dir) {
+return;
+}
+while ((entry = readdir(dir)) !=
Implementation of a USB Media Transfer Device device for easy
filesharing. Read-only. No access control inside qemu, it will
happily export any file it is able to open to the guest, i.e.
standard unix access rights for the qemu process apply.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
On 04/23/14 10:31, Gerd Hoffmann wrote:
Implementation of a USB Media Transfer Device device for easy
filesharing. Read-only. No access control inside qemu, it will
happily export any file it is able to open to the guest, i.e.
standard unix access rights for the qemu process apply.
On Mi, 2014-04-23 at 16:09 +0200, Laszlo Ersek wrote:
On 04/23/14 10:31, Gerd Hoffmann wrote:
Implementation of a USB Media Transfer Device device for easy
filesharing. Read-only. No access control inside qemu, it will
happily export any file it is able to open to the guest, i.e.
