[Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Stefan Hajnoczi
v4: * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] v3: * Add clang 3.5.0 warning fixes * Squash David Ahern's clang struct definition warnings fix v2: * Squash in Jiri's fix for rocker format string specifiers [Peter] * Squash in Windows build fix [Peter] * Both

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Peter Maydell
On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: > v4: > * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] > > v3: > * Add clang 3.5.0 warning fixes > * Squash David Ahern's clang struct definition warnings fix > > v2: > * Squash in Jiri's fix for rocker format string

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Peter Maydell
On 12 March 2015 at 14:43, Peter Maydell wrote: > On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: >> v4: >> * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] >> >> v3: >> * Add clang 3.5.0 warning fixes >> * Squash David Ahern's clang struct definition warnings fix >

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Stefan Hajnoczi
On Thu, Mar 12, 2015 at 3:03 PM, Peter Maydell wrote: > On 12 March 2015 at 14:43, Peter Maydell wrote: >> On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: >>> v4: >>> * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] >>> >>> v3: >>> * Add clang 3.5.0 warning fixes >>

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Stefan Hajnoczi
On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote: > On 12 March 2015 at 14:43, Peter Maydell wrote: > > On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: > >> v4: > >> * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] > >> > >> v3: > >> * Add clang 3.5.0 wa

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Peter Maydell
On 12 March 2015 at 17:50, Stefan Hajnoczi wrote: > This pull request contains patches that fail mingw compilation and > glib version requirements. They passed in patchew: > http://qemu.patchew.org/testing/log/%3c1426170808-6343-1-git-send-email-stefa...@redhat.com%3E > > Peter's build script is

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Paolo Bonzini
On 12/03/2015 20:58, Stefan Hajnoczi wrote: > David, Jiri, Scott: The minimum required glib version is 2.12 so > glib APIs that were added later cannot be used. Also note the > Windows integer constant warning above. > > My build environments didn't hit these issues so we need to go > around on

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-12 Thread Fam Zheng
On Thu, 03/12 17:50, Stefan Hajnoczi wrote: > Hi Fam, > This pull request contains patches that fail mingw compilation and > glib version requirements. They passed in patchew: > http://qemu.patchew.org/testing/log/%3c1426170808-6343-1-git-send-email-stefa...@redhat.com%3E > > Peter's build script

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-13 Thread Peter Maydell
On 13 March 2015 at 02:32, Fam Zheng wrote: > On Thu, 03/12 17:50, Stefan Hajnoczi wrote: >> Hi Fam, >> This pull request contains patches that fail mingw compilation and >> glib version requirements. They passed in patchew: >> http://qemu.patchew.org/testing/log/%3c1426170808-6343-1-git-send-ema

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-13 Thread Scott Feldman
On Thu, Mar 12, 2015 at 12:58 PM, Stefan Hajnoczi wrote: > On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote: >> On 12 March 2015 at 14:43, Peter Maydell wrote: >> > On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: >> >> v4: >> >> * Drop clang 3.5.0 fixes since they break with olde

Re: [Qemu-devel] [PULL v4 00/11] Net patches

2015-03-16 Thread Peter Maydell
On 14 March 2015 at 04:19, Scott Feldman wrote: > On Thu, Mar 12, 2015 at 12:58 PM, Stefan Hajnoczi wrote: >> On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote: >>> Also fails to build with our minimum glib version > I verified on glibc 2.13 for the second issue. Note that "glib" an