Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-08 Thread David Kiarie
On Mon, Aug 8, 2016 at 12:06 PM, Peter Xu wrote: > On Tue, Aug 02, 2016 at 03:17:20PM +0300, David Kiarie wrote: > > On Tue, Aug 2, 2016 at 3:12 PM, Peter Xu wrote: > > > > > On Tue, Aug 02, 2016 at 02:58:55PM +0300, David Kiarie wrote: > > > > > Sure. David, so do you like to do it or I cook th

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-08 Thread Peter Xu
On Tue, Aug 02, 2016 at 03:17:20PM +0300, David Kiarie wrote: > On Tue, Aug 2, 2016 at 3:12 PM, Peter Xu wrote: > > > On Tue, Aug 02, 2016 at 02:58:55PM +0300, David Kiarie wrote: > > > > Sure. David, so do you like to do it or I cook this patch? :) > > > > > > If there are no objections I will l

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread David Kiarie
On Tue, Aug 2, 2016 at 3:16 PM, Jan Kiszka wrote: > On 2016-08-02 13:58, David Kiarie wrote: > > > > > > On Tue, Aug 2, 2016 at 1:28 PM, Peter Xu > > wrote: > > > > On Tue, Aug 02, 2016 at 10:46:13AM +0200, Jan Kiszka wrote: > > > On 2016-08-02 10:36, Peter Xu w

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Peter Xu
On Tue, Aug 02, 2016 at 02:58:55PM +0300, David Kiarie wrote: > > Sure. David, so do you like to do it or I cook this patch? :) > > If there are no objections I will look at this employing Jan's approach: > associating a write with an address space. Do you mean to translate current stl_le_phys()

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread David Kiarie
On Tue, Aug 2, 2016 at 3:12 PM, Peter Xu wrote: > On Tue, Aug 02, 2016 at 02:58:55PM +0300, David Kiarie wrote: > > > Sure. David, so do you like to do it or I cook this patch? :) > > > > If there are no objections I will look at this employing Jan's approach: > > associating a write with an addr

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Jan Kiszka
On 2016-08-02 13:58, David Kiarie wrote: > > > On Tue, Aug 2, 2016 at 1:28 PM, Peter Xu > wrote: > > On Tue, Aug 02, 2016 at 10:46:13AM +0200, Jan Kiszka wrote: > > On 2016-08-02 10:36, Peter Xu wrote: > > > On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kis

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Jan Kiszka
On 2016-08-02 14:17, David Kiarie wrote: > > > On Tue, Aug 2, 2016 at 3:12 PM, Peter Xu > wrote: > > On Tue, Aug 02, 2016 at 02:58:55PM +0300, David Kiarie wrote: > > > Sure. David, so do you like to do it or I cook this patch? :) > > > > If there are n

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread David Kiarie
On Tue, Aug 2, 2016 at 1:28 PM, Peter Xu wrote: > On Tue, Aug 02, 2016 at 10:46:13AM +0200, Jan Kiszka wrote: > > On 2016-08-02 10:36, Peter Xu wrote: > > > On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kiszka wrote: > > > > > > [...] > > > > > >>> static MemTxResult vtd_mem_ir_read(void *opaque

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Peter Xu
On Tue, Aug 02, 2016 at 10:46:13AM +0200, Jan Kiszka wrote: > On 2016-08-02 10:36, Peter Xu wrote: > > On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kiszka wrote: > > > > [...] > > > >>> static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr, > >>> @@ -2209,11 +2250,17 @@ static MemTxResul

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Jan Kiszka
On 2016-08-02 10:36, Peter Xu wrote: > On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kiszka wrote: > > [...] > >>> static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr, >>> @@ -2209,11 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void *opaque, >>> hwaddr addr, >>> { >>> int ret

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Jan Kiszka
[always keep the list in CC] On 2016-08-02 10:54, David Kiarie wrote: > > > On Tue, Aug 2, 2016 at 11:46 AM, Jan Kiszka > wrote: > > On 2016-08-02 10:36, Peter Xu wrote: > > On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kiszka wrote: > > > > [...]

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-02 Thread Peter Xu
On Mon, Aug 01, 2016 at 06:39:05PM +0200, Jan Kiszka wrote: [...] > > static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr, > > @@ -2209,11 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void *opaque, > > hwaddr addr, > > { > > int ret = 0; > > MSIMessage from = {}, to = {};

Re: [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-08-01 Thread Jan Kiszka
On 2016-07-21 19:53, Michael S. Tsirkin wrote: > From: Peter Xu > > This patch enables SID validation. Invalid interrupts will be dropped. > > Signed-off-by: Peter Xu > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > include/hw/i386/intel_iommu.h | 17 +++

[Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR

2016-07-21 Thread Michael S. Tsirkin
From: Peter Xu This patch enables SID validation. Invalid interrupts will be dropped. Signed-off-by: Peter Xu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 17 +++ hw/i386/intel_iommu.c | 69 +