Re: [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback

2019-02-07 Thread Samuel Thibault
Philippe Mathieu-Daudé, le jeu. 07 févr. 2019 19:31:49 +0100, a ecrit: > > +if (ret < 0) { > > +g_critical("Failed to send packet, ret: %ld", (long) ret); > > From the v3 discussion [*] I thought send_packet() would return a > gssize, then we'd use G_GSSIZE_FORMAT here (and similarly

Re: [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback

2019-02-07 Thread Philippe Mathieu-Daudé
Hi Samuel, On 2/7/19 3:03 PM, Samuel Thibault wrote: > From: Marc-André Lureau > > Use a more descriptive name for the callback. > > Reuse the SlirpWriteCb type. Wrap it to check that all data has been written. > > Return a ssize_t for potential error handling and data-loss reporting. > >

[Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback

2019-02-07 Thread Samuel Thibault
From: Marc-André Lureau Use a more descriptive name for the callback. Reuse the SlirpWriteCb type. Wrap it to check that all data has been written. Return a ssize_t for potential error handling and data-loss reporting. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault ---