Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread peter
> "Andreas" == Andreas Färber writes: >> Thanks; applied to target-arm.next. Andreas> Also if there is a reset bug, then fixing that in its own Andreas> patch would better allow backporting that to 1.6.1. The way Andreas> it is right now with no Cc: line for qemu-stable, the Andreas> release

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 20 August 2013 15:01, Andreas Färber wrote: > Peter Ch., please call such a patch "imx_epit: " rather than "ARM: " > since it affects only your device. (PMM, can you fix?) Yes, I fixed it to say "hw/timer/imx_epit: ..." -- PMM

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Andreas Färber
Am 20.08.2013 15:46, schrieb Peter Maydell: > On 5 August 2013 02:27, Peter Chubb wrote: >> >> When imx_epit.c was last refactored, a common usecase (comparison >> register zero) broke. This patch fixes that, and simplifies the code >> yet more. It also fixes a major thinko in the reset path ---

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 5 August 2013 02:27, Peter Chubb wrote: > > When imx_epit.c was last refactored, a common usecase (comparison > register zero) broke. This patch fixes that, and simplifies the code > yet more. It also fixes a major thinko in the reset path --- the > wrong bits in the control register were bei

[Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-04 Thread Peter Chubb
When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in the reset path --- the wrong bits in the control register were being cleared. Signed-off-by: Peter Chubb Reviewed-by: