Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-08 Thread Eric Blake
On 09/06/2015 09:55 PM, Wen Congyang wrote: >> I haven't looked at them yet, but really like Max's approach for >> separating BDS from BB by treating BB without BDS as an empty media >> case, and BDS without a BB as something that can then be manipulated to >> be associated with another BDS or BB.

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-06 Thread Wen Congyang
On 09/02/2015 11:00 PM, Eric Blake wrote: > On 09/01/2015 07:25 PM, Wen Congyang wrote: >> On 09/01/2015 11:34 PM, Eric Blake wrote: >>> On 08/31/2015 06:55 PM, Wen Congyang wrote: >>> >> +This command is still a work in progress. It doesn't support all >> +block drivers. Stay away from it

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-02 Thread Eric Blake
On 09/01/2015 07:25 PM, Wen Congyang wrote: > On 09/01/2015 11:34 PM, Eric Blake wrote: >> On 08/31/2015 06:55 PM, Wen Congyang wrote: >> > +This command is still a work in progress. It doesn't support all > +block drivers. Stay away from it unless you want it to help with > +its

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-01 Thread Wen Congyang
On 09/01/2015 11:34 PM, Eric Blake wrote: > On 08/31/2015 06:55 PM, Wen Congyang wrote: > +This command is still a work in progress. It doesn't support all +block drivers. Stay away from it unless you want it to help with +its development. >>> >>> Maybe we should name it

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-01 Thread Eric Blake
On 08/31/2015 06:55 PM, Wen Congyang wrote: >>> +This command is still a work in progress. It doesn't support all >>> +block drivers. Stay away from it unless you want it to help with >>> +its development. >> >> Maybe we should name it 'x-child-add' for now, so that we aren't baking >> ourselves

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-08-31 Thread Eric Blake
On 08/11/2015 01:51 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > blockdev.c | 79 >

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-08-31 Thread Wen Congyang
On 09/01/2015 03:04 AM, Eric Blake wrote: > On 08/11/2015 01:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> blockdev.c | 79

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-08-31 Thread Wen Congyang
On 09/01/2015 03:04 AM, Eric Blake wrote: > On 08/11/2015 01:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> blockdev.c | 79

[Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-08-11 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- blockdev.c | 79 qapi/block-core.json | 40 ++