Re: [Qemu-devel] [Patch v2 04/29] s390x/cpumodel: introduce CPU features

2016-08-16 Thread David Hildenbrand
> On 08/08/2016 05:32 PM, David Hildenbrand wrote: > > In general this this very good. Mostly bike shedding and naming. Thanks! > > > +/* indexed by feature number for easy lookup */ > > +static const S390FeatDef s390_features[] = { > > +FEAT_INIT("n3", S390_FEAT_TYPE_STFL, 0,

Re: [Qemu-devel] [Patch v2 04/29] s390x/cpumodel: introduce CPU features

2016-08-16 Thread Christian Borntraeger
On 08/08/2016 05:32 PM, David Hildenbrand wrote: In general this this very good. Mostly bike shedding and naming. > +/* indexed by feature number for easy lookup */ > +static const S390FeatDef s390_features[] = { > +FEAT_INIT("n3", S390_FEAT_TYPE_STFL, 0, "Instructions marked as n3"),

[Qemu-devel] [Patch v2 04/29] s390x/cpumodel: introduce CPU features

2016-08-08 Thread David Hildenbrand
From: Michael Mueller The patch introduces s390x CPU features (most of them refered to as facilities) along with their discription and some functions that will be helpful when working with the features later on. Please note that we don't introduce all known CPU