Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2019-01-14 Thread remy . noel
On Sat, Jan 12, 2019 at 08:30:08AM +, Stefan Hajnoczi wrote: Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Thanks ! Remy

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2019-01-12 Thread Stefan Hajnoczi
On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: > From: Remy Noel > > It is possible for an io_poll/read/write callback to be concurrently executed > along > with an aio_set_fd_handlers. This can cause all sorts of problems, like > a NULL callback or a bad opaque

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2019-01-08 Thread Stefan Hajnoczi
On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: > From: Remy Noel > > It is possible for an io_poll/read/write callback to be concurrently executed > along > with an aio_set_fd_handlers. This can cause all sorts of problems, like > a NULL callback or a bad opaque

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2019-01-07 Thread remy . noel
On Thu, Dec 20, 2018 at 04:20:28PM +0100, Remy Noel wrote: From: Remy Noel It is possible for an io_poll/read/write callback to be concurrently executed along with an aio_set_fd_handlers. This can cause all sorts of problems, like a NULL callback or a bad opaque pointer. V2: * Do not use

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-24 Thread Remy NOEL
On 12/21/18 12:34 PM, Paolo Bonzini wrote: FWIW, I had missed the early version that used RCU, but lockcnt is already very RCU-like, so not using RCU is the right thing to do. The difference between lockcnt and RCU is that cleanup is done by the reader instead of a separate thread. Because we

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-21 Thread Paolo Bonzini
On 20/12/18 17:37, Stefan Hajnoczi wrote: > On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: >> From: Remy Noel >> >> It is possible for an io_poll/read/write callback to be concurrently >> executed along >> with an aio_set_fd_handlers. This can cause all sorts of

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread Stefan Hajnoczi
On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: > From: Remy Noel > > It is possible for an io_poll/read/write callback to be concurrently executed > along > with an aio_set_fd_handlers. This can cause all sorts of problems, like > a NULL callback or a bad opaque

[Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-20 Thread remy . noel
From: Remy Noel It is possible for an io_poll/read/write callback to be concurrently executed along with an aio_set_fd_handlers. This can cause all sorts of problems, like a NULL callback or a bad opaque pointer. V2: * Do not use RCU anymore as it inccurs a performance loss V3: * Don't