Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Maran Wilson
On 6/17/2019 10:56 AM, Liran Alon wrote: Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") introduced new IOCTLs to extract and restore vCPU state related to Intel VMX & AMD SVM. Utilize these IOCTLs to add support for migration of VMs which are running nested hypervisors.

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Paolo Bonzini
On 18/06/19 17:48, Dr. David Alan Gilbert wrote: >> Currently, KVM folks (including myself), haven’t decided yet to expose >> vmcs12 struct layout to userspace but instead to still leave it opaque. >> The formal size of this size is VMCS12_SIZE (defined in kernel as 0x1000). I >> was wondering if

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Liran Alon
> On 18 Jun 2019, at 18:48, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >>> On 18 Jun 2019, at 12:03, Dr. David Alan Gilbert >>> wrote: >>> >>> * Liran Alon (liran.a...@oracle.com) wrote: +static const VMStateDescription vmstate_vmx_vmcs12 =

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Liran Alon
> On 18 Jun 2019, at 12:03, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> +static const VMStateDescription vmstate_vmx_vmcs12 = { >> +.name = "cpu/kvm_nested_state/vmx/vmcs12", >> +.version_id = 1, >> +.minimum_version_id = 1, >> +.needed =

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > On 18 Jun 2019, at 12:03, Dr. David Alan Gilbert > > wrote: > > > > * Liran Alon (liran.a...@oracle.com) wrote: > >> > >> +static const VMStateDescription vmstate_vmx_vmcs12 = { > >> + .name = "cpu/kvm_nested_state/vmx/vmcs12", > >> + .versio

Re: [Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-18 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") > introduced new IOCTLs to extract and restore vCPU state related to > Intel VMX & AMD SVM. > > Utilize these IOCTLs to add support for migration of VMs which are > running nested

[Qemu-devel] [QEMU PATCH v3 7/9] KVM: i386: Add support for save and restore nested state

2019-06-17 Thread Liran Alon
Kernel commit 8fcc4b5923af ("kvm: nVMX: Introduce KVM_CAP_NESTED_STATE") introduced new IOCTLs to extract and restore vCPU state related to Intel VMX & AMD SVM. Utilize these IOCTLs to add support for migration of VMs which are running nested hypervisors. Reviewed-by: Nikita Leshenko Signed-off-