Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults

2016-03-04 Thread Peter Maydell
On 4 March 2016 at 15:03, Sergey Sorokin wrote: > Do we really need to rearrange the code? > In pseudo-code the level is set explicitly as well, in case of a fault. That's why when I originally brought the point up I said "but I'm not sure it's worth rearranging that code"... If you want to neate

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults

2016-03-04 Thread Sergey Sorokin
03.03.2016, 19:54, "Peter Maydell" : >  On 3 March 2016 at 16:37, Sergey Fedorov wrote: >>   On 03.03.2016 17:55, Peter Maydell wrote: >>>   Yes, this patch is definitely fixing a bug; I'm just mentioning that other >>>   code path because it seems to be the result of previously fixing the bug >

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults

2016-03-03 Thread Peter Maydell
On 3 March 2016 at 16:37, Sergey Fedorov wrote: > On 03.03.2016 17:55, Peter Maydell wrote: >> Yes, this patch is definitely fixing a bug; I'm just mentioning that other >> code path because it seems to be the result of previously fixing the bug >> for a particular special case... >> >> > > Ah, ri

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults

2016-03-03 Thread Sergey Fedorov
On 03.03.2016 17:55, Peter Maydell wrote: > On 3 March 2016 at 14:48, Sergey Fedorov wrote: >> On 03.03.2016 16:49, Peter Maydell wrote: >>> On 2 March 2016 at 19:19, Sergey Fedorov wrote: On 02.03.2016 21:04, Sergey Sorokin wrote: > Qemu reports translation fault on 1st level instead of

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix translation level on early translation faults

2016-03-03 Thread Peter Maydell
On 3 March 2016 at 14:48, Sergey Fedorov wrote: > On 03.03.2016 16:49, Peter Maydell wrote: >> On 2 March 2016 at 19:19, Sergey Fedorov wrote: >>> On 02.03.2016 21:04, Sergey Sorokin wrote: Qemu reports translation fault on 1st level instead of 0th level in case of AArch64 address trans