Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 22.12.2015 17:46, Kevin Wolf wrote: > Enough innocent images have died because users called 'qemu-img snapshot' > while > the VM was still running. Educating the users doesn't seem to be a working > strategy, so this series adds locking to qcow2 that refuses to access the > image > read-write

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 01/13/2016 11:56 AM, Markus Armbruster wrote: Kevin Wolf writes: Am 23.12.2015 um 11:47 hat Daniel P. Berrange geschrieben: On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

Am 23.12.2015 um 16:11 hat Vasiliy Tolstov geschrieben: > 2015-12-23 18:08 GMT+03:00 Denis V. Lunev : > > you should do this by asking running QEMU not by > > qemu-img, which is badly wrong. > > > > Den > > > Ok, if this is possible via qmp/hmp qemu, no problem. It's

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

Am 24.12.2015 um 06:43 hat Denis V. Lunev geschrieben: > On 12/22/2015 07:46 PM, Kevin Wolf wrote: > >Enough innocent images have died because users called 'qemu-img snapshot' > >while > >the VM was still running. Educating the users doesn't seem to be a working > >strategy, so this series adds

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 01/11/2016 07:33 PM, Kevin Wolf wrote: Am 24.12.2015 um 06:43 hat Denis V. Lunev geschrieben: On 12/22/2015 07:46 PM, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

Am 24.12.2015 um 06:41 hat Denis V. Lunev geschrieben: > On 12/24/2015 02:19 AM, Max Reitz wrote: > >So the benefits of a qcow2 flag are only minor ones. However, I > >personally believe that automatic unlock on crash is a very minor > >benefit as well. That should never happen in practice anyway,

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Mon, Jan 11, 2016 at 05:47:06PM +0100, Kevin Wolf wrote: > Am 24.12.2015 um 06:41 hat Denis V. Lunev geschrieben: > > On 12/24/2015 02:19 AM, Max Reitz wrote: > > >So the benefits of a qcow2 flag are only minor ones. However, I > > >personally believe that automatic unlock on crash is a very

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 24.12.2015 06:41, Denis V. Lunev wrote: > On 12/24/2015 02:19 AM, Max Reitz wrote: >> So the benefits of a qcow2 flag are only minor ones. However, I >> personally believe that automatic unlock on crash is a very minor >> benefit as well. That should never happen in practice anyway, and a >>

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: > > As an alternative, can we introduce .bdrv_flock() in protocol drivers, with > > similar semantics to flock(2) or lockf(3)? That way all formats can benefit, > > and

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/23/2015 05:57 PM, Vasiliy Tolstov wrote: 2015-12-22 19:46 GMT+03:00 Kevin Wolf : Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 18:08 GMT+03:00 Denis V. Lunev : > you should do this by asking running QEMU not by > qemu-img, which is badly wrong. > > Den Ok, if this is possible via qmp/hmp qemu, no problem. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/23/2015 05:57 PM, Vasiliy Tolstov wrote: 2015-12-22 19:46 GMT+03:00 Kevin Wolf : Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/24/2015 08:41 AM, Denis V. Lunev wrote: On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/22/2015 07:46 PM, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that refuses to access the image read-write from two

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > > On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: > > > As an alternative, can we introduce .bdrv_flock() in protocol drivers, > > > with > > > similar

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > > On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: > > > As an alternative, can we introduce .bdrv_flock() in protocol drivers, > > > with > > > similar

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/23/2015 03:29 PM, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: As an alternative, can we introduce .bdrv_flock() in

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Wed, Dec 23, 2015 at 03:41:01PM +0300, Denis V. Lunev wrote: > On 12/23/2015 03:29 PM, Daniel P. Berrange wrote: > >On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: > >>On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > >>>On Wed, Dec 23, 2015 at 11:14:12AM +0800,

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/23/2015 03:34 PM, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: On Wed, Dec 23, 2015 at 11:14:12AM +0800, Fam Zheng wrote: As an alternative, can we introduce .bdrv_flock() in

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On Wed, Dec 23, 2015 at 03:47:00PM +0300, Denis V. Lunev wrote: > On 12/23/2015 03:34 PM, Daniel P. Berrange wrote: > >On Wed, Dec 23, 2015 at 03:15:50PM +0300, Roman Kagan wrote: > >>On Wed, Dec 23, 2015 at 10:47:22AM +, Daniel P. Berrange wrote: > >>>On Wed, Dec 23, 2015 at 11:14:12AM +0800,

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

On 12/23/2015 06:14 AM, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that refuses