Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-06 Thread Stefan Hajnoczi
On Tue, May 05, 2015 at 01:20:19PM +0200, Kevin Wolf wrote: > Am 05.05.2015 um 12:28 hat Stefan Hajnoczi geschrieben: > > On Mon, May 04, 2015 at 12:58:13PM +0200, Kevin Wolf wrote: > > > Am 01.05.2015 um 16:23 hat Stefan Hajnoczi geschrieben: > > > > On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alber

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-05 Thread Alberto Garcia
On Tue 05 May 2015 01:20:19 PM CEST, Kevin Wolf wrote: > Though looking at the code again I see now that c->table_size isn't > consistently used. The I/O requests still use s->cluster_size. We > should either use it everywhere or not introduce it at all. c->table_size is necessary in order to cal

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-05 Thread Kevin Wolf
Am 05.05.2015 um 12:28 hat Stefan Hajnoczi geschrieben: > On Mon, May 04, 2015 at 12:58:13PM +0200, Kevin Wolf wrote: > > Am 01.05.2015 um 16:23 hat Stefan Hajnoczi geschrieben: > > > On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote: > > > > Qcow2Cache *qcow2_cache_create(BlockDriver

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-05 Thread Stefan Hajnoczi
On Mon, May 04, 2015 at 12:58:13PM +0200, Kevin Wolf wrote: > Am 01.05.2015 um 16:23 hat Stefan Hajnoczi geschrieben: > > On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote: > > > Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int num_tables) > > > { > > > BDRVQcowState *s

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-04 Thread Kevin Wolf
Am 01.05.2015 um 16:23 hat Stefan Hajnoczi geschrieben: > On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote: > > Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int num_tables) > > { > > BDRVQcowState *s = bs->opaque; > > Qcow2Cache *c; > > -int i; > > > > c

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-01 Thread Stefan Hajnoczi
On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote: > Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int num_tables) > { > BDRVQcowState *s = bs->opaque; > Qcow2Cache *c; > -int i; > > c = g_new0(Qcow2Cache, 1); > c->size = num_tables; > +c->table_s