Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

2019-09-13 Thread John Snow
On 9/13/19 5:00 PM, Philippe Mathieu-Daudé wrote: > On 9/13/19 10:01 PM, John Snow wrote: >> On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: >>> Event format ending with newlines confuse the trace reports. >>> Forbid them. >>> >>> Add a check to refuse new format added with trailing newline:

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

2019-09-13 Thread Philippe Mathieu-Daudé
On 9/13/19 10:01 PM, John Snow wrote: > On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: >> Event format ending with newlines confuse the trace reports. >> Forbid them. >> >> Add a check to refuse new format added with trailing newline: >> >> $ make >> [...] >> GEN hw/misc/trace.h >>

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

2019-09-13 Thread John Snow
On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: > Event format ending with newlines confuse the trace reports. > Forbid them. > > Add a check to refuse new format added with trailing newline: > > $ make > [...] > GEN hw/misc/trace.h > Traceback (most recent call last): >