Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-02 Thread Wen Congyang
On 07/02/2015 03:54 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 07/02/2015 02:42 AM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fu

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-02 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/02/2015 02:42 AM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: > >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/01/2015 03:01 AM, Dr. Davi

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Wen Congyang
On 07/02/2015 02:42 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fu

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: > >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: > On 06/27/2015 03:03 AM, Dr. Davi

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Wen Congyang
On 07/01/2015 04:11 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: >>> >>> >>> > Ah, I hadn't r

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-07-01 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: > > > > > > > >>> Ah, I hadn't realised you could do that; so do you just do: > >>> > >

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-30 Thread Wen Congyang
On 07/01/2015 03:01 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: > > > >>> Ah, I hadn't realised you could do that; so do you just do: >>> >>> migrate_set_parameter colo on >>> migrate -d -b tcp:otherhho

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-30 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: > > Ah, I hadn't realised you could do that; so do you just do: > > > > migrate_set_parameter colo on > > migrate -d -b tcp:otherhhost:port > > > > How does the secondary know to feed that data

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-28 Thread Wen Congyang
On 06/27/2015 03:03 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 06/24/2015 10:07 PM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (ghost...@gmail.com) wrote: At 2015/6/19 18:49, Stefan Hajnoczi Wrote: > On Fri, Jun 19, 2015 at 08:54:56AM +0800

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-26 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 06/24/2015 10:07 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (ghost...@gmail.com) wrote: > >> At 2015/6/19 18:49, Stefan Hajnoczi Wrote: > >>> On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: > On 06/19/2015 12:06 AM, Stef

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-24 Thread Wen Congyang
On 06/24/2015 10:07 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (ghost...@gmail.com) wrote: >> At 2015/6/19 18:49, Stefan Hajnoczi Wrote: >>> On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > On Thu, Jun 18, 2015 at 10:36:

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-24 Thread Dr. David Alan Gilbert
* Wen Congyang (ghost...@gmail.com) wrote: > At 2015/6/19 18:49, Stefan Hajnoczi Wrote: > >On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: > >>On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > >>>On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: > At 2015/6/18 20:55, St

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Wen Congyang
On 06/19/2015 06:49 PM, Stefan Hajnoczi wrote: > On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: >> On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: >>> On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: > On Thu, Jun 18, 20

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Stefan Hajnoczi
On Mon, Jun 22, 2015 at 09:56:24PM +0800, Wen Congyang wrote: > >The NBD connect should not be performed during downtime, regardless of > >whether a monitor command is used or not. > > Why? NBD connection establishment takes unbounded time. It can extend the downtime period and cause users to no

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-23 Thread Wen Congyang
At 2015/6/23 21:42, Stefan Hajnoczi Wrote: On Mon, Jun 22, 2015 at 09:56:24PM +0800, Wen Congyang wrote: The NBD connect should not be performed during downtime, regardless of whether a monitor command is used or not. Why? NBD connection establishment takes unbounded time. It can extend the

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-22 Thread Wen Congyang
On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: >> At 2015/6/18 20:55, Stefan Hajnoczi Wrote: >>> On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-22 Thread Wen Congyang
At 2015/6/22 20:39, Stefan Hajnoczi Wrote: On Sat, Jun 20, 2015 at 11:31:52AM +0800, Wen Congyang wrote: At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-22 Thread Stefan Hajnoczi
On Sat, Jun 20, 2015 at 11:31:52AM +0800, Wen Congyang wrote: > At 2015/6/19 18:49, Stefan Hajnoczi Wrote: > >On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: > >>On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > >>>On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: > At

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Wen Congyang
At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: > On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > > On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: > >> At 2015/6/18 20:55, Stefan Hajnoczi Wrote: > >>> On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: >

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: > On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: >> At 2015/6/18 20:55, Stefan Hajnoczi Wrote: >>> On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: > At 2015/6/18 20:55, Stefan Hajnoczi Wrote: > >On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: > >>+void bdrv_connect(BlockDriverState *bs, Error **errp) > >>+{ > >>+BlockDriver *drv = bs->drv; > >>+ > >>+if (drv &

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Wen Congyang
At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: +void bdrv_connect(BlockDriverState *bs, Error **errp) +{ +BlockDriver *drv = bs->drv; + +if (drv && drv->bdrv_connect) { +drv->bdrv_connect(bs, errp); +} else if (bs->fil

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-18 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote: > +void bdrv_connect(BlockDriverState *bs, Error **errp) > +{ > +BlockDriver *drv = bs->drv; > + > +if (drv && drv->bdrv_connect) { > +drv->bdrv_connect(bs, errp); > +} else if (bs->file) { > +bdrv_connect(bs-