Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 7/8] block: remove legacy I/O throttling

2017-06-26 Thread Stefan Hajnoczi
On Fri, Jun 23, 2017 at 03:46:59PM +0300, Manos Pitsidianakis wrote: > @@ -1914,45 +1878,115 @@ int blk_commit_all(void) > /* throttling disk I/O limits */ > void blk_set_io_limits(BlockBackend *blk, ThrottleConfig *cfg) > { > -throttle_group_config(&blk->public.throttle_group_member, cfg);

Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 7/8] block: remove legacy I/O throttling

2017-06-26 Thread Manos Pitsidianakis
On Mon, Jun 26, 2017 at 04:44:44PM +0100, Stefan Hajnoczi wrote: On Fri, Jun 23, 2017 at 03:46:59PM +0300, Manos Pitsidianakis wrote: -void blk_io_limits_disable(BlockBackend *blk) +void blk_io_limits_disable(BlockBackend *blk, Error **errp) { -assert(blk->public.throttle_group_member.throt

Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 7/8] block: remove legacy I/O throttling

2017-06-27 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 01:45:07AM +0300, Manos Pitsidianakis wrote: > On Mon, Jun 26, 2017 at 04:44:44PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jun 23, 2017 at 03:46:59PM +0300, Manos Pitsidianakis wrote: > > > -void blk_io_limits_disable(BlockBackend *blk) > > > +void blk_io_limits_disable(Blo