Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-17 Thread Jeff Cody
On Mon, Apr 17, 2017 at 04:27:19PM +0800, Fam Zheng wrote: > On Fri, 04/14 09:51, Stefan Hajnoczi wrote: > > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > > > @@ -398,11 +399,15 @@ void bdrv_drain_all(void); > > > */\ > > > a

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-17 Thread Fam Zheng
On Fri, 04/14 09:51, Stefan Hajnoczi wrote: > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > > @@ -398,11 +399,15 @@ void bdrv_drain_all(void); > > */\ > > assert(!bs_->wakeup); \ > > bs_-

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-16 Thread Fam Zheng
On Sun, 04/16 10:37, Stefan Hajnoczi wrote: > On Sat, Apr 15, 2017 at 01:10:02AM +0800, Paolo Bonzini wrote: > > > > > > On 14/04/2017 16:51, Stefan Hajnoczi wrote: > > > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > > >> @@ -398,11 +399,15 @@ void bdrv_drain_all(void); > > >> */

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-16 Thread Stefan Hajnoczi
On Sat, Apr 15, 2017 at 01:10:02AM +0800, Paolo Bonzini wrote: > > > On 14/04/2017 16:51, Stefan Hajnoczi wrote: > > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > >> @@ -398,11 +399,15 @@ void bdrv_drain_all(void); > >> */\ > >>

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-14 Thread Paolo Bonzini
On 14/04/2017 16:51, Stefan Hajnoczi wrote: > On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: >> @@ -398,11 +399,15 @@ void bdrv_drain_all(void); >> */\ >> assert(!bs_->wakeup); \ >> bs_->w

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-14 Thread Stefan Hajnoczi
On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > @@ -398,11 +399,15 @@ void bdrv_drain_all(void); > */\ > assert(!bs_->wakeup); \ > bs_->wakeup = true;\ > -

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9-rc5 v2] block: Drain BH in bdrv_drained_begin

2017-04-14 Thread Stefan Hajnoczi
On Fri, Apr 14, 2017 at 9:02 AM, Fam Zheng wrote: > During block job completion, nothing is preventing > block_job_defer_to_main_loop_bh from being called in a nested > aio_poll(), which is a trouble, such as in this code path: > > qmp_block_commit > commit_active_start > bdrv_re