Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > Some of the historical command line opts that had their > keys in in a completely flat namespace are now represented > by QAPI schemas that use a nested structs. When converting > the QemuOpts to QObject, there is no information about > c

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > Some of the historical command line opts that had their > > keys in in a completely flat namespace are now represented > > by QAPI schemas that use a nested structs. When con

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > > Some of the historical command line opts that had their > > > keys in in a completely flat namespace are now

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > > Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > > > > Some of the historical command line opts

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Kevin Wolf
Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > > On Thu, Oct 06, 2016 at 05:10:42PM +0200, Kevin Wolf wrote: > > > > Am 30.09.2016 um 16:45 hat Daniel P. Berr

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: > Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: > > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: > > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: > > > > On Thu, Oct 06, 2016 at 05:10:42PM +0200,

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-06 Thread Eric Blake
On 10/06/2016 10:30 AM, Kevin Wolf wrote: >>> So, considering that it is a purely internally used type not visible in >>> QMP, would it make sense to change NetLegacy to be a flat union instead, >>> with NetLegacyOptions as the common base? Then you get the same flat >>> namespace that we always h

Re: [Qemu-devel] [Qemu-block] [PATCH v14 10/21] qapi: permit auto-creating nested structs

2016-10-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Oct 06, 2016 at 05:51:57PM +0200, Kevin Wolf wrote: >> Am 06.10.2016 um 17:39 hat Daniel P. Berrange geschrieben: >> > On Thu, Oct 06, 2016 at 05:30:05PM +0200, Kevin Wolf wrote: >> > > Am 06.10.2016 um 17:18 hat Daniel P. Berrange geschrieben: >> > > > On T