Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-24 Thread Stefan Hajnoczi
On Wed, Jun 24, 2015 at 10:47:47AM +0800, Fam Zheng wrote: > On Tue, 06/16 17:07, Stefan Hajnoczi wrote: > > On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote: > > 2. Is this about thread safety? (No, it's about exclusive access to a > >BDS *within* the AioContext.) > > As it has to q

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-24 Thread Paolo Bonzini
On 24/06/2015 04:47, Fam Zheng wrote: >> > 2. Is this about thread safety? (No, it's about exclusive access to a >> >BDS *within* the AioContext.) > As it has to quiesce iothreads as well (for now it's even more urgent than > exclusive access within the same AioContext), I'd rather take it a

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-23 Thread Fam Zheng
On Wed, 06/24 10:47, Fam Zheng wrote: > On Tue, 06/16 17:07, Stefan Hajnoczi wrote: > > On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote: > > > +/** > > > + * bdrv_lock: > > > + * > > > + * Begin a temporary exclusive accessing by locking the BDS. > > > + */ > > > +void bdrv_lock(BlockDriv

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-23 Thread Fam Zheng
On Tue, 06/16 17:07, Stefan Hajnoczi wrote: > On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote: > > +/** > > + * bdrv_lock: > > + * > > + * Begin a temporary exclusive accessing by locking the BDS. > > + */ > > +void bdrv_lock(BlockDriverState *bs); > > + > > +/** > > + * bdrv_unlock: > >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-16 Thread Stefan Hajnoczi
On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote: > +/** > + * bdrv_lock: > + * > + * Begin a temporary exclusive accessing by locking the BDS. > + */ > +void bdrv_lock(BlockDriverState *bs); > + > +/** > + * bdrv_unlock: > + * > + * End a exclusive accessing. > + */ > +void bdrv_unlock(Bl