Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: use internal filter node in backup

2017-08-17 Thread Stefan Hajnoczi
On Wed, Aug 16, 2017 at 11:11:44PM +0300, Manos Pitsidianakis wrote: > On Wed, Aug 16, 2017 at 02:25:44PM +0100, Stefan Hajnoczi wrote: > > On Tue, Aug 15, 2017 at 11:18:53AM +0300, Manos Pitsidianakis wrote: > > > @@ -3142,7 +3174,7 @@ static bool should_update_child(BdrvChild *c, > > >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: use internal filter node in backup

2017-08-16 Thread Manos Pitsidianakis
On Wed, Aug 16, 2017 at 02:25:44PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 15, 2017 at 11:18:53AM +0300, Manos Pitsidianakis wrote: block/backup.c currently uses before write notifiers on the targeted node. We can create a filter node instead to intercept write requests for the backup job on

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: use internal filter node in backup

2017-08-16 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 11:18:53AM +0300, Manos Pitsidianakis wrote: > block/backup.c currently uses before write notifiers on the targeted > node. We can create a filter node instead to intercept write requests > for the backup job on the BDS level, instead of the BlockBackend level. > > This is