Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-10-10 Thread Alexander Graf
On 08.10.2012, at 04:09, Li Zhang wrote: On Wed, Sep 26, 2012 at 5:03 PM, Alexander Graf ag...@suse.de wrote: On 26.09.2012, at 10:50, Li Zhang zhlci...@gmail.com wrote: Thanks Gerd. Hi Alex, Can this patch be pushed to upstream? Gerd, do you want to take this through the usb

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-10-07 Thread Li Zhang
On Wed, Sep 26, 2012 at 5:03 PM, Alexander Graf ag...@suse.de wrote: On 26.09.2012, at 10:50, Li Zhang zhlci...@gmail.com wrote: Thanks Gerd. Hi Alex, Can this patch be pushed to upstream? Gerd, do you want to take this through the usb queue? If I get s formal ack from you I can also

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-09-26 Thread Li Zhang
Thanks Gerd. Hi Alex, Can this patch be pushed to upstream? Thanks. -:) On Wed, Sep 26, 2012 at 2:29 PM, Gerd Hoffmann kra...@redhat.com wrote: On 09/26/12 06:20, Li Zhang wrote: Would you please have a look at my patch when you have time? Because it is related with USB, so I hope to get

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-09-26 Thread Alexander Graf
On 26.09.2012, at 10:50, Li Zhang zhlci...@gmail.com wrote: Thanks Gerd. Hi Alex, Can this patch be pushed to upstream? Gerd, do you want to take this through the usb queue? If I get s formal ack from you I can also take it into ppc-next, but it doesn't quite belong there :). Alex

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-09-24 Thread Li Zhang
Hi Gerd, Any suggestion? Many thanks. -:) On Wed, Sep 19, 2012 at 1:59 AM, Alexander Graf ag...@suse.de wrote: On 09/18/2012 07:36 PM, Alexander Graf wrote: On 09/03/2012 07:25 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create

Re: [Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-18 Thread Alexander Graf
On 09/03/2012 07:25 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-09-18 Thread Alexander Graf
On 09/18/2012 07:36 PM, Alexander Graf wrote: On 09/03/2012 07:25 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to

Re: [Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-18 Thread Li Zhang
On Wed, Sep 19, 2012 at 1:36 AM, Alexander Graf ag...@suse.de wrote: On 09/03/2012 07:25 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code hard to

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 1/1] Add USB option in machine options

2012-09-18 Thread Li Zhang
On Wed, Sep 19, 2012 at 1:59 AM, Alexander Graf ag...@suse.de wrote: On 09/18/2012 07:36 PM, Alexander Graf wrote: On 09/03/2012 07:25 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this

Re: [Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-16 Thread Li Zhang
Hi all, What should I do to improve this patch? Can anyone give more suggestions? Thanks. -:) On Mon, Sep 3, 2012 at 1:25 PM, Li Zhang zhlci...@gmail.com wrote: When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this

[Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-02 Thread Li Zhang
When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB option in machine options. All the