Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-28 Thread Alexander Graf
On 25.10.2011, at 21:38, Scott Wood wrote: > On 10/14/2011 01:44 AM, Alexander Graf wrote: >> Wouldn't a simple >> >> if (kvm_enabled()) { >>return; >> } >> >> in the beginning of the function make more sense? There's no code connecting >> the in-qemu and the in-kvm decrementors atm, so an

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-25 Thread Scott Wood
On 10/14/2011 01:44 AM, Alexander Graf wrote: > Wouldn't a simple > > if (kvm_enabled()) { > return; > } > > in the beginning of the function make more sense? There's no code connecting > the in-qemu and the in-kvm decrementors atm, so any logic applying to the > in-qemu one is moot for kvm

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-16 Thread David Gibson
On Fri, Oct 14, 2011 at 05:46:14PM +1100, David Gibson wrote: > On Fri, Oct 14, 2011 at 08:44:06AM +0200, Alexander Graf wrote: > > > > On 14.10.2011, at 08:36, David Gibson wrote: > > > > > On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: > > >> > > >> On 14.10.2011, at 07:19, Da

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-13 Thread David Gibson
On Fri, Oct 14, 2011 at 08:44:06AM +0200, Alexander Graf wrote: > > On 14.10.2011, at 08:36, David Gibson wrote: > > > On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: > >> > >> On 14.10.2011, at 07:19, David Gibson wrote: > >> > >>> In __cpu_ppc_store_decr(), we set up a regular

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-13 Thread Alexander Graf
On 14.10.2011, at 08:36, David Gibson wrote: > On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: >> >> On 14.10.2011, at 07:19, David Gibson wrote: >> >>> In __cpu_ppc_store_decr(), we set up a regular timer used to trigger >>> decrementer interrupts. This is necessary to impleme

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-13 Thread David Gibson
On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: > > On 14.10.2011, at 07:19, David Gibson wrote: > > > In __cpu_ppc_store_decr(), we set up a regular timer used to trigger > > decrementer interrupts. This is necessary to implement the decrementer > > properly under TCG, but is un