Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-22 Thread Fabien Chouteau
On 07/19/2013 07:19 PM, Scott Wood wrote: > On 07/19/2013 04:22:46 AM, Fabien Chouteau wrote: >> On 07/18/2013 10:37 PM, Scott Wood wrote: >> > On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: >> >> The BD is full, we will have to put the rest of padding in the next one. >> > >> > What rest of pad

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-19 Thread Scott Wood
On 07/19/2013 04:22:46 AM, Fabien Chouteau wrote: On 07/18/2013 10:37 PM, Scott Wood wrote: > On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: >> The BD is full, we will have to put the rest of padding in the next one. > > What rest of padding? I thought you said rx_padding was 2 somehow?

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-19 Thread Fabien Chouteau
On 07/18/2013 10:37 PM, Scott Wood wrote: > On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: >> On 07/17/2013 11:02 PM, Scott Wood wrote: >>> On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: Can you explain a possible error scenario? >>> >>> 126 byte packet, no fcb. rx_padding is 4 for CRC.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-18 Thread Scott Wood
On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: On 07/17/2013 11:02 PM, Scott Wood wrote: > On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: >> On 07/16/2013 07:50 PM, Scott Wood wrote: >> > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-18 Thread Fabien Chouteau
On 07/17/2013 11:02 PM, Scott Wood wrote: > On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: >> On 07/16/2013 07:50 PM, Scott Wood wrote: >> > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> >> > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Scott Wood
On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: On 07/16/2013 07:50 PM, Scott Wood wrote: > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> >> +if (*size == etsec->rx_padding) { >> >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Fabien Chouteau
On 07/17/2013 12:22 PM, Alexander Graf wrote: > > On 17.07.2013, at 12:17, Fabien Chouteau wrote: > >> On 07/16/2013 07:50 PM, Scott Wood wrote: >>> On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: On 07/16/2013 04:06 AM, Scott Wood wrote: > On 07/10/2013 12:10:02 PM, Fabien Chouteau wr

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Fabien Chouteau
On 07/17/2013 10:29 AM, Alexander Graf wrote: > > > Am 17.07.2013 um 10:24 schrieb Fabien Chouteau : > >> On 07/16/2013 06:54 PM, Scott Wood wrote: >>> On 07/16/2013 11:15:51 AM, Fabien Chouteau wrote: On 07/16/2013 05:37 PM, Alexander Graf wrote: > On 07/16/2013 05:28 PM, Fabien Choute

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Alexander Graf
On 17.07.2013, at 12:17, Fabien Chouteau wrote: > On 07/16/2013 07:50 PM, Scott Wood wrote: >> On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >>> On 07/16/2013 04:06 AM, Scott Wood wrote: On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: > +obj-$(CONFIG_ETSEC) += etsec.o etsec_registe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Fabien Chouteau
On 07/16/2013 07:50 PM, Scott Wood wrote: > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> >> +obj-$(CONFIG_ETSEC) += etsec.o etsec_registers.o etsec_rings.o >> >> etsec_miim.o >> > >> > Maybe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Alexander Graf
Am 17.07.2013 um 10:24 schrieb Fabien Chouteau : > On 07/16/2013 06:54 PM, Scott Wood wrote: >> On 07/16/2013 11:15:51 AM, Fabien Chouteau wrote: >>> On 07/16/2013 05:37 PM, Alexander Graf wrote: On 07/16/2013 05:28 PM, Fabien Chouteau wrote: > On 07/16/2013 04:06 AM, Scott Wood wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-17 Thread Fabien Chouteau
On 07/16/2013 06:54 PM, Scott Wood wrote: > On 07/16/2013 11:15:51 AM, Fabien Chouteau wrote: >> On 07/16/2013 05:37 PM, Alexander Graf wrote: >> > On 07/16/2013 05:28 PM, Fabien Chouteau wrote: >> >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> >>> On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Scott Wood
On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: On 07/16/2013 04:06 AM, Scott Wood wrote: > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. >> >> Signed-off-by: Fabien Chouteau > > From the code comments I gather

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Scott Wood
On 07/16/2013 11:15:51 AM, Fabien Chouteau wrote: On 07/16/2013 05:37 PM, Alexander Graf wrote: > On 07/16/2013 05:28 PM, Fabien Chouteau wrote: >> On 07/16/2013 04:06 AM, Scott Wood wrote: >>> On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: This implementation doesn't include ring priorit

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Fabien Chouteau
On 07/16/2013 05:37 PM, Alexander Graf wrote: > On 07/16/2013 05:28 PM, Fabien Chouteau wrote: >> On 07/16/2013 04:06 AM, Scott Wood wrote: >>> On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. Signed-off-by: Fa

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Alexander Graf
On 07/16/2013 05:28 PM, Fabien Chouteau wrote: On 07/16/2013 04:06 AM, Scott Wood wrote: On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. Signed-off-by: Fabien Chouteau From the code comments I gather this has been tes

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-16 Thread Fabien Chouteau
On 07/16/2013 04:06 AM, Scott Wood wrote: > On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: >> This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. >> >> Signed-off-by: Fabien Chouteau > > From the code comments I gather this has been tested on VxWorks. Has it > been tested

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-15 Thread Scott Wood
On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: > This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. > > Signed-off-by: Fabien Chouteau >From the code comments I gather this has been tested on VxWorks. Has it been tested on Linux, or anywhere else? > --- > default-conf