Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-07-23 Thread Matthew Garrett
Dave Airlie wrote the dirty handling code, so Cc:ing him. I suspect transitioning offb over to a similar design would be fine by him. On Mon, Jul 23, 2012 at 04:40:21PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 17:25 -0500, Anthony Liguori wrote: > > > If a user asks for somet

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-07-23 Thread Benjamin Herrenschmidt
On Mon, 2012-07-23 at 16:40 +1000, Benjamin Herrenschmidt wrote: > > Note to Matthew: cirrusdrmfb is a LOT SLOWER than offb for a similar > SW only dumb framebuffer, probably has to do with the way it does the > "dirty" stuff, not sure ... > > Why not draw directly into the emulated vram ? More

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-07-22 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 17:25 -0500, Anthony Liguori wrote: > If a user asks for something and we can't make it work, we should fail. Note that QEMU's cirrus works fine with the new kernel cirrusdrmfb, so I say we should allow it (needs to be able to the powerpc device .mak as well tho. It shouldn

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Anthony Liguori
On 06/27/2012 05:14 PM, Alexander Graf wrote: On 28.06.2012, at 00:05, Benjamin Herrenschmidt wrote: On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. Otherwise we'd just silently ignore the option. You guys love ab

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 28.06.2012, at 00:05, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: >> >> It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. >> Otherwise we'd just silently ignore the option. > > You guys love aborts too much. For a high level opti

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 23:42 +0200, Alexander Graf wrote: > > It shouldn't be an #if 0 but an if (cirrus) hw_abort() then though. > Otherwise we'd just silently ignore the option. You guys love aborts too much. For a high level option like -vga I'd rather just fallback to "std" (like afaik some ot

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 27.06.2012, at 23:39, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 14:08 +0200, Alexander Graf wrote: >> Ben, mind to push a working SLOF, we we can just enable all of it in >> one go and don't have to commit #if 0'ed code? >> >> Rest looks reasonable to me. > > Sure, SLOF was gated

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Benjamin Herrenschmidt
On Wed, 2012-06-27 at 14:08 +0200, Alexander Graf wrote: > Ben, mind to push a working SLOF, we we can just enable all of it in > one go and don't have to commit #if 0'ed code? > > Rest looks reasonable to me. Sure, SLOF was gated by the memop patch but we can push it now. However I'd rather leav

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: Add support for -vga option

2012-06-27 Thread Alexander Graf
On 18.06.2012, at 11:34, Li Zhang wrote: > Also instanciate the USB keyboard and mouse when that option is used > (you can still use -device to create individual devices without all > the defaults) > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Li Zhang > --- > hw/spapr.c | 43 ++