Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-05-01 Thread Cédric Le Goater
On 05/01/2018 08:39 AM, David Gibson wrote: > On Thu, Apr 26, 2018 at 09:20:11AM +0200, Cédric Le Goater wrote: >> On 04/26/2018 08:46 AM, David Gibson wrote: >>> On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: On 04/17/2018 09:17 AM, David Gibson wrote: > In

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-05-01 Thread David Gibson
On Thu, Apr 26, 2018 at 09:20:11AM +0200, Cédric Le Goater wrote: > On 04/26/2018 08:46 AM, David Gibson wrote: > > On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: > >> On 04/17/2018 09:17 AM, David Gibson wrote: > >>> In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-04-26 Thread Cédric Le Goater
On 04/26/2018 08:46 AM, David Gibson wrote: > On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: >> On 04/17/2018 09:17 AM, David Gibson wrote: >>> In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized >>> based on on ppc64_radix_guest(). Which seems reasonable,

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-04-26 Thread David Gibson
On Wed, Apr 25, 2018 at 11:52:18AM +0200, Cédric Le Goater wrote: > On 04/17/2018 09:17 AM, David Gibson wrote: > > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized > > based on on ppc64_radix_guest(). Which seems reasonable, except that > > ppc64_radix_guest() is based on

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-04-25 Thread Cédric Le Goater
On 04/17/2018 09:17 AM, David Gibson wrote: > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized > based on on ppc64_radix_guest(). Which seems reasonable, except that > ppc64_radix_guest() is based on spapr->patb_entry which is only set up > in spapr_machine_reset, called