Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

2017-02-26 Thread David Gibson
On Fri, Feb 24, 2017 at 05:30:23PM +1100, Richard Henderson wrote: > On 02/24/2017 03:50 PM, David Gibson wrote: > > Although I guess they'd shrink right down again if we put an > > env->xer_mask in. Thoughts on that option Richard? > > Why would xer_mask shrink the code? I can't see that we'd b

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

2017-02-23 Thread Nikunj Dadhania
On 24 February 2017 at 04:23, David Gibson wrote: > On Fri, Feb 24, 2017 at 09:34:32AM +1100, Richard Henderson wrote: >> On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: >> > Richard Henderson writes: >> > > These functions are becoming quite large. Are they performance critical >> > > enough

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

2017-02-23 Thread David Gibson
On Fri, Feb 24, 2017 at 06:11:30AM +0530, Nikunj Dadhania wrote: > On 24 February 2017 at 04:23, David Gibson > wrote: > > On Fri, Feb 24, 2017 at 09:34:32AM +1100, Richard Henderson wrote: > >> On 02/23/2017 05:40 PM, Nikunj A Dadhania wrote: > >> > Richard Henderson writes: > >> > > These func

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] target/ppc: support for 32-bit carry and overflow

2017-02-23 Thread Richard Henderson
On 02/24/2017 03:50 PM, David Gibson wrote: Although I guess they'd shrink right down again if we put an env->xer_mask in. Thoughts on that option Richard? Why would xer_mask shrink the code? I can't see that we'd be able to eliminate any code using the mask. r~