Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/6] target-ppc: Implement unsigned quadword left/right shift and unit tests

2017-01-05 Thread Eric Blake
On 01/05/2017 03:45 PM, jos...@linux.vnet.ibm.com wrote: >> >>> +{ 0, 0, 0ULL, 0, 200, false }, >> >> If you are going to support shifts larger than 127, your testsuite >> should include a shift of a non-zero number. Also, if you are going to >> implicitly truncate the shift value into range,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/6] target-ppc: Implement unsigned quadword left/right shift and unit tests

2017-01-05 Thread joserz
Hello Eric, Thank you very much for your review. Please, read my responses and questions below. Happy 2017. On Tue, Jan 03, 2017 at 09:20:37AM -0600, Eric Blake wrote: > On 12/19/2016 10:47 AM, Jose Ricardo Ziviani wrote: > > This commit implements functions to right and left shifts and the > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/6] target-ppc: Implement unsigned quadword left/right shift and unit tests

2017-01-03 Thread joserz
On Tue, Jan 03, 2017 at 10:53:33AM +1100, David Gibson wrote: > On Mon, Dec 19, 2016 at 02:47:39PM -0200, Jose Ricardo Ziviani wrote: > > This commit implements functions to right and left shifts and the > > unittest for them. Such functions is needed due to instructions > > that requires them. > >