Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-11 Thread Richard Henderson
On 12/11/18 1:35 PM, Mark Cave-Ayland wrote: > Looking at your profiles above, the primary hotspot appears to be > helper_lookup_tb_ptr(). However as someone quite new to the TCG parts of > QEMU, I > couldn't tell you whether or not this is to be expected. > > Perhaps a question for Richard:

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-11 Thread Mark Cave-Ayland
On 11/12/2018 01:20, David Gibson wrote: > On Mon, Dec 10, 2018 at 09:54:51PM +0100, BALATON Zoltan wrote: >> On Mon, 10 Dec 2018, David Gibson wrote: >>> On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote: On Fri, 7 Dec 2018, Mark Cave-Ayland wrote: > This patchset is an

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-10 Thread BALATON Zoltan
On Tue, 11 Dec 2018, David Gibson wrote: On Mon, Dec 10, 2018 at 09:54:51PM +0100, BALATON Zoltan wrote: Yes, I don't really know what these tests use but I think "lame" test is mostly floating point but tried with "lame_vmx" which should at least use some vector ops and "mplayer -benchmark"

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-10 Thread David Gibson
On Mon, Dec 10, 2018 at 09:54:51PM +0100, BALATON Zoltan wrote: > On Mon, 10 Dec 2018, David Gibson wrote: > > On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote: > > > On Fri, 7 Dec 2018, Mark Cave-Ayland wrote: > > > > This patchset is an attempt at trying to improve the VMX

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-10 Thread BALATON Zoltan
On Mon, 10 Dec 2018, Richard Henderson wrote: On 12/10/18 2:54 PM, BALATON Zoltan wrote: Tried it on i5 650 which has: sse sse2 ssse3 sse4_1 sse4_2. I assume x86_64 should be supported but not sure what are the CPU requirements. Not quite. I only support avx1 and later. I thought about

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-10 Thread Richard Henderson
On 12/10/18 2:54 PM, BALATON Zoltan wrote: >> What was your host machine.  IIUC this change will only improve >> performance if the host tcg backend is able to implement TCG vector >> ops in terms of vector ops on the host. > > Tried it on i5 650 which has: sse sse2 ssse3 sse4_1 sse4_2. I assume

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-10 Thread BALATON Zoltan
On Mon, 10 Dec 2018, David Gibson wrote: On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote: On Fri, 7 Dec 2018, Mark Cave-Ayland wrote: This patchset is an attempt at trying to improve the VMX (Altivec) instruction performance by making use of the new TCG vector operations where

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-09 Thread David Gibson
On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote: > On Fri, 7 Dec 2018, Mark Cave-Ayland wrote: > > This patchset is an attempt at trying to improve the VMX (Altivec) > > instruction > > performance by making use of the new TCG vector operations where possible. > > This is very

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 0/6] target/ppc: convert VMX instructions to use TCG vector operations

2018-12-09 Thread BALATON Zoltan
On Fri, 7 Dec 2018, Mark Cave-Ayland wrote: This patchset is an attempt at trying to improve the VMX (Altivec) instruction performance by making use of the new TCG vector operations where possible. This is very welcome, thanks for doing this. In order to use TCG vector operations, the