Re: [Qemu-devel] [Qemu-stable] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-06-12 Thread Stefan Hajnoczi
On Tue, Jun 11, 2013 at 05:59:31PM -0500, mdroth wrote: > On Thu, May 30, 2013 at 04:14:46PM +0200, Stefan Hajnoczi wrote: > > I'm not sure why we check the mode only after invoking popen(3) but we > > need to close the file pointer. > > > > Spotted by Coverity. > > > > Cc: Juan Quintela > > Cc:

Re: [Qemu-devel] [Qemu-stable] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-06-11 Thread mdroth
On Thu, May 30, 2013 at 04:14:46PM +0200, Stefan Hajnoczi wrote: > I'm not sure why we check the mode only after invoking popen(3) but we > need to close the file pointer. > > Spotted by Coverity. > > Cc: Juan Quintela > Cc: qemu-sta...@nongnu.org > Signed-off-by: Stefan Hajnoczi Ping, looking