Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-21 Thread Michael Tokarev
20.03.2014 19:51, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be done for new machine types only. I thought about

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-21 Thread Gerd Hoffmann
On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote: So what should we do then? Should I send an updated patch which sets 070002 in the multiport case too? Yes, that would be great. cheers, Gerd

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-21 Thread BALATON Zoltan
On Fri, 21 Mar 2014, Gerd Hoffmann wrote: On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote: So what should we do then? Should I send an updated patch which sets 070002 in the multiport case too? Yes, that would be great. OK, I'll resubmit it after pc-2.1 is added also with the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Mon, 17 Mar 2014, Gerd Hoffmann wrote: C 07 Communication controller 00 Serial controller 00 8250 01 16450 02 16550 What about multi_serial_pci_init() -- should it too set prog-if like this? I'm not completely sure what the correct

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Michael Tokarev
10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be done for new machine types only. Paolo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be done for new machine types only. Why? I tried

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:01, BALATON Zoltan ha scritto: On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 17:01, BALATON Zoltan ha scritto: On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:58, BALATON Zoltan ha scritto: Classes (or anything guest-visible in fact) must never ever be changed for the same machine type. It's a rule. The class did not change only the prog interface field after it (which is guest visible but I think most guests just ignore it). So

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-17 Thread Gerd Hoffmann
C 07 Communication controller 00 Serial controller 00 8250 01 16450 02 16550 What about multi_serial_pci_init() -- should it too set prog-if like this? I'm not completely sure what the correct value should be for

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-14 Thread Michael Tokarev
10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ On Thu, 27 Feb 2014, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- hw/char/serial-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/serial-pci.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-14 Thread BALATON Zoltan
On Fri, 14 Mar 2014, Michael Tokarev wrote: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ On Thu, 27 Feb 2014, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- hw/char/serial-pci.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-14 Thread BALATON Zoltan
On Fri, 14 Mar 2014, BALATON Zoltan wrote: On Fri, 14 Mar 2014, Michael Tokarev wrote: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ On Thu, 27 Feb 2014, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- hw/char/serial-pci.c